sidekiq-worker-killer sidekiq/util has been removed in 6.5.0

see https://github.com/mperham/sidekiq/compare/v6.4.2...v6.5.0

Follows https://github.com/mperham/sidekiq/pull/5340

Jun 08 '22 18:06 bf4

I think this broke our sidekiq when I deployed it. Hold on

NoMethodError: undefined method call' for nil:NilClass (Most recent call first) Show 3 non-project frames NoMethodError: undefined method call' for nil:NilClass (Most recent call first)
Hide 4 non-project frames
File /app/vendor/bundle/ruby/3.0.0/gems/sidekiq-6.5.0/lib/sidekiq/processor.rb line 73 in rescue in run
File /app/vendor/bundle/ruby/3.0.0/gems/sidekiq-6.5.0/lib/sidekiq/processor.rb line 67 in run
File /app/vendor/bundle/ruby/3.0.0/gems/sidekiq-6.5.0/lib/sidekiq/component.rb line 8 in watchdog
File /app/vendor/bundle/ruby/3.0.0/gems/sidekiq-6.5.0/lib/sidekiq/component.rb line 17 in block in safe_thread

Jun 09 '22 13:06 bf4

Since worker_killer is a server middleware, you should include the new Module as noted here:

https://github.com/mperham/sidekiq/blob/main/docs/middleware.md#updated-api

You can then access the identity with config[:identity]. It looks like that's all you need sidekiq/util for.

Jun 09 '22 16:06 mperham

@mperham Thanks. Updated the PR and added a test for finding the process from the processset for the 'identity' to ensure it doesn't fail again

Jun 09 '22 18:06 bf4

Why not just have a new version that only supports 6.5+? Let people use an old version of swk if they want to run an old version of Sidekiq.

Jun 09 '22 19:06 mperham

re "Why not just have a new version that only supports 6.5+? Let people use an old version of swk if they want to run an old version of Sidekiq."

I'm not a maintainer of this. 👍 on that, though

Jun 09 '22 21:06 bf4

Still getting failures. Gotta look deeper. maybe something about the heartbeat? maybe something redis-specific which is why it's not showing up in tests?

https://github.com/klaxit/sidekiq-worker-killer/pull/21#issuecomment-1151124349

looks like somehow Processor is getting a nil @callback

I'm trying to reproduce it locally and get more context

my local gem changes, fwiw

sidekiq 6.4.2 -> 6.5.0 sidekiq-pro 5.3.1 -> 5.5.0

Jun 10 '22 01:06 bf4

Scout APM’s gem breaks Sidekiq 6.5 with this error, see their issue tracker.

Jun 10 '22 01:06 mperham

@mperham Thanks for that. I thought I might have noticed it on local server shutdown but hadn't reproduced it yet

https://github.com/scoutapp/scout_apm_ruby/issues/449 https://github.com/mperham/sidekiq/issues/5375

Jun 10 '22 01:06 bf4

Why not just have a new version that only supports 6.5+? Let people use an old version of swk if they want to run an old version of Sidekiq.

It's a bad idea to add breaking changes to minor update, isn't ?

Jun 16 '22 20:06 slayer

Sidekiq::Processor is not a public API nor is sidekiq/util. I take compatibility very seriously for documented, public APIs, deprecate things and document them in major version release notes.

Jun 16 '22 20:06 mperham