gitlist icon indicating copy to clipboard operation
gitlist copied to clipboard

Crash on empty repositories

Open RobinBoers opened this issue 1 year ago • 2 comments

Empty repositories give a 500 with the following error in my logs:

[2024-08-18T22:45:08.116012+02:00] request.CRITICAL: Uncaught PHP Exception GitList\SCM\Exception\CommandException: "fatal: Not a valid object name HEAD " at /home/robinb/domains/git.geheimesite.nl/src/SCM/System/Git/CommandLine.php line 315 {"exception":"[object] (GitList\\SCM\\Exception\\CommandException(code: 0): fatal: Not a valid object name HEAD\n at /home/robinb/domains/git.geheimesite.nl/src/SCM/System/Git/CommandLine.php:315)"} []

I would expect this to show me a message "this repository is empty", similar to cgit, GitHub or GitLab do. Or a 404. Not a 500 at least.

RobinBoers avatar Aug 18 '24 20:08 RobinBoers

I would be willing to create a PR to fix this, but I'm unfamiliar with this codebase, so it might take a while.

RobinBoers avatar Aug 18 '24 20:08 RobinBoers

You could catch that exception at the controller and use Symfony's flash message system to give the warning. I really like the idea.

klaussilveira avatar Aug 19 '24 17:08 klaussilveira