tusk
tusk copied to clipboard
Update electron to v11
Fixes #314 #315 #308 and their related issues.
Done by executing yarn add electron@latest
.
Screenshot:
For tests to pass, I created the PR #316
Thanks for your attention and work on Tusk!
also fixes https://github.com/klaussinani/tusk/issues/327 https://github.com/klaussinani/tusk/issues/326 https://github.com/klaussinani/tusk/issues/325 https://github.com/klaussinani/tusk/issues/324 https://github.com/klaussinani/tusk/issues/323 https://github.com/klaussinani/tusk/issues/321 https://github.com/klaussinani/tusk/issues/320 https://github.com/klaussinani/tusk/issues/319 https://github.com/klaussinani/tusk/issues/318 https://github.com/klaussinani/tusk/issues/311 https://github.com/klaussinani/tusk/issues/310
I tried locally and it works with npm start
.
However, I tried running the release command and it fails
npm run release
on ubuntu 20.04
> [email protected] release /home/arjun/work/tusk-test/tusk
> build --publish always
sh: 1: build: not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! [email protected] release: `build --publish always`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the [email protected] release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/arjun/.npm/_logs/2021-02-19T10_25_49_341Z-debug.log
Is there a way to proceed here?
It cannot run release on the main branch as well. So I don't think it is the problem from this PR. There is also a workaround mentioned in this issue https://github.com/klaussinani/tusk/issues/308#issuecomment-777928524. Maybe you can try with that. I used only npm start
until there is a fix release.
I tried locally and it works with
npm start
.However, I tried running the release command and it fails
npm run release
on ubuntu 20.04> [email protected] release /home/arjun/work/tusk-test/tusk > build --publish always sh: 1: build: not found npm ERR! file sh npm ERR! code ELIFECYCLE npm ERR! errno ENOENT npm ERR! syscall spawn npm ERR! [email protected] release: `build --publish always` npm ERR! spawn ENOENT npm ERR! npm ERR! Failed at the [email protected] release script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /home/arjun/.npm/_logs/2021-02-19T10_25_49_341Z-debug.log
Is there a way to proceed here?
This PR has solved the command in build step https://github.com/klaussinani/tusk/pull/332. There's also a build and release provided in the forked repository here: https://github.com/Trip09/tusk/releases/tag/v1.0.0
Thanks @fonylew :+1: