signale icon indicating copy to clipboard operation
signale copied to clipboard

fix(types): issue with typing for types option

Open kucherenko opened this issue 4 months ago • 0 comments

Fix types of types option, based on the documentation and source code I can provide not fully described object for types e.g.

const {Signale} = require('signale');

const options = {
  types: {
    error: {
      badge: '!!',
      label: 'fatal error'
    },
    success: {
      badge: '++',
      label: 'huge success'
    }
  }
};

const signale = new Signale();
signale.error('Default Error Log');
signale.success('Default Success Log');

const custom = new Signale(options);
custom.error('Custom Error Log');
custom.success('Custom Success Log');

or

const {Signale} = require('signale');

const options = {
  types: {
    error: {
      badge: '!!',
      label: 'fatal error'
    },
    success: {
      badge: '++',
      label: 'huge success'
    }
  }
};

const signale = new Signale();
signale.error('Default Error Log');
signale.success('Default Success Log');

const custom = new Signale(options);
custom.error('Custom Error Log');
custom.success('Custom Success Log');

In the PR I suggest the fix for typescript types only, the documentation and javascript code continue working as usual.

kucherenko avatar Feb 12 '24 09:02 kucherenko