LGWebOSRemote
LGWebOSRemote copied to clipboard
klattimer
Added patch to fix ssl.wrap_socket error
Pushing a temporary fix for the issue https://github.com/klattimer/LGWebOSRemote/issues/165
Since the ssl library has been updated, the ws4py library started failing. The fix https://github.com/Lawouach/WebSocket-for-Python/commit/9ffee997a128ea9d7b09fb1dcf4aa280d25ebdc9 has already been merged but there is no new release of the ws4py library, and is not expected any sooner.
I am incorporating the fix as a patch in LGWebOSRemote. The patch is tested for scan, auth, listInputs and setInput options only, and it works as a temporary fix.
What is blocking the upstream release? Surely this should have been resolved by now, I've been taking a bit of flak over it for a while.
Not sure. But it looks like they are planning a new release soon https://github.com/Lawouach/WebSocket-for-Python/issues/288 . They also mentioned the issue https://github.com/Lawouach/WebSocket-for-Python/pull/283 which affects LGWebOSRemote.
@sazawal I don't want to accept this PR, but I also don't want to leave this issue unresolved. It's been a while now, has ws4py fixed the upstream issue? Is there a better fix?
@klattimer I just went through the comments here https://github.com/Lawouach/WebSocket-for-Python/issues/288 and it looks like the issue is fixed, but I did not get time to test it on LGWebOSRemote. If you find it is working, please go ahead with rejecting the PR and closing the issue. I don't think there is a better fix as long as LGWebOSRemote depends on ws4py.
Two weeks ago https://github.com/Lawouach/WebSocket-for-Python/releases/tag/0.6.0 was released and I can confirm that it works with this version of ws4py. This patch is no longer needed.
