kakarot-ssj icon indicating copy to clipboard operation
kakarot-ssj copied to clipboard

dev: replace `unwrap` with `expect`

Open greged93 opened this issue 2 years ago • 5 comments

Replace all occurrences of unwrap with expect, making it a lot easier to debug during integration testing. Having unwrap in the codebase causes the VM to crash with Result::unwrap failed., whereas expect returns the error message passed to expect.

greged93 avatar Dec 05 '23 12:12 greged93

hey @greged93 may i try to work on this one? Should i find by myself which felt252 error message to give as input to expect function? thank you.

TAdev0 avatar Dec 05 '23 18:12 TAdev0

@TAdev0 Could you wait a bit until we scope this issue with more precision? For now we didn't identify which parts could really benefit from this.

enitrat avatar Dec 07 '23 14:12 enitrat

Sure, thank you!

TAdev0 avatar Dec 07 '23 16:12 TAdev0

@greged93 @enitrat is better debugging with expect during integration tests still needed? if yes did you scope which parts need better debugging experience?

TAdev0 avatar Jan 27 '24 11:01 TAdev0

for now SSJ is not on the priority list, so not a lot of stuff going on here

enitrat avatar Jan 27 '24 11:01 enitrat