Typescript conversion + big changes.

[UrielCh]

Hi

I have just opened a PR containing a Typescript version of puppeteer-extra

Would a full Typescript PR for this project be accepted?

After spending a full week on my puppeteer-extra fork, fakebrowser look's so easy to work with.

Is there some WIP part of the code that should not be touched?

Can I add some export to fakebrowser to use it as a lib to manage fingerprint data?

[Hoodognik]

@UrielCh Hello. i trying to use your fork but something went wrong. Maybe you can leave any guide to use your update?

[UrielCh]

send me an error message plz.

the active branch is: heavy-duty

but depend of my fork of pptr-extra, that is being reimplemente on the main project

see: https://github.com/berstend/puppeteer-extra/issues/646 https://github.com/berstend/puppeteer-extra/pull/649

[UrielCh]

something like that should work:

npm install -g pnpm yarn
git clone https://github.com/UrielCh/puppeteer-extra-ts
cd puppeteer-extra-ts;
npx json -I -f package.json -e 'this.resolutions={}'
yarn install
yarn bootstrap
yarn lerna add --dev puppeteer@14
yarn lerna link
yarn lerna run build --concurrency 1
cd ..
git clone https://github.com/UrielCh/fakebrowser.git -b heavy-duty
cd fakebrowser
pnpm install
pnpm run build

[Hoodognik]

@UrielCh thank you. I will try and later will comeback with report of result. actually could be nice have ability install packages just with "yarn add" or "npm install" with automatic build in install process. I make app used nodegui and want to integrate this. In this case abit difficult to implement that to current project

[UrielCh]

berstend mostly accept my change, but integrating them one by one, will take time.

[kbondnewera]

Hello @UrielCh i am trying configure with tutorial you posted

npm install -g pnpm yarn git clone https://github.com/UrielCh/puppeteer-extra-ts cd puppeteer-extra-ts; npx json -I -f package.json -e 'this.resolutions={}' yarn install yarn bootstrap yarn lerna add --dev puppeteer@14 yarn lerna link yarn lerna run build --concurrency 1 cd .. git clone https://github.com/UrielCh/fakebrowser.git -b heavy-duty cd fakebrowser pnpm install pnpm run build

and getting error

: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

[kbondnewera]

src/core/FakeBrowser.ts:7:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

7 import { PuppeteerExtra } from 'puppeteer-extra'; ~~~~~~~~~~~~~~

src/core/PptrPatcher.ts:9:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

9 import { PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra' ~~~~~~~~~~~~~~

src/core/Driver.ts:4:20 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

4 import { addExtra, PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra' ~~~~~~~~~~~~~~

Found 3 errors.

 ELIFECYCLE  Command failed with exit code 1.

[UrielCh]

I used my for of PuppeteerExtra to make it works, that why it do not build out of the box.

[kbondnewera]

Hello @UrielCh i am very need talk with you, have a email or telegram or contact for i am talk with you.

[kbondnewera]

i am declared your module and now another error please help me friend setup this i am pay you if need

src/core/FakeBrowser.ts:7:32 - error TS2307: Cannot find module 'puppeteer-extra-ts' or its corresponding type declarations.

7 import { PuppeteerExtra } from 'puppeteer-extra-ts'; ~~~~~~~~~~~~~~~~~~~~

[kbondnewera]

i am running and 352 lies like in the normal version this is correct, please help me friend i am pay you @UrielCh

[UrielCh]

send me a PM in the Discord server, I'm always connected in All-For-Bots as uri.

[Iquaridys]

src/core/FakeBrowser.ts:7:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

7 import { PuppeteerExtra } from 'puppeteer-extra'; ~~~~~~~~~~~~~~

src/core/PptrPatcher.ts:9:10 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

9 import { PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra' ~~~~~~~~~~~~~~

src/core/Driver.ts:4:20 - error TS2614: Module '"puppeteer-extra"' has no exported member 'PuppeteerExtra'. Did you mean to use 'import PuppeteerExtra from "puppeteer-extra"' instead?

4 import { addExtra, PuppeteerExtra, PuppeteerExtraPlugin } from 'puppeteer-extra' ~~~~~~~~~~~~~~

Found 3 errors.

 ELIFECYCLE  Command failed with exit code 1.

i got this error too