Konrad Komorowski

My 0.02 here: (1) > This would, however, make working with non-autogenerated IDs more annoying as you would have to explicitly wrap the ID value with the type, for example:...

Since the image seems to be fine (e.g. it's possible to create a new container from the same image and Pyright might run), I'll try to add retries in this...

Just looking through the CI logs, I also found instances where the operation just timed out (total CI run reached 15 minutes):

Thanks, will give it a try! Maybe it happened before too, it just felt like something that started recently... FWIW GitHub workflows do have network issues occasionally. But note that...

Okay, I think we need to add `frozen_default=True` in places like this: https://github.com/strawberry-graphql/strawberry/blob/be9a2d53ccadf018b6754d131dda4ed76476a8d9/strawberry/object_type.py#L190 https://github.com/strawberry-graphql/strawberry/blob/be9a2d53ccadf018b6754d131dda4ed76476a8d9/strawberry/object_type.py#L207 See: https://github.com/python/cpython/issues/99957 and the updated spec here: https://typing.readthedocs.io/en/latest/spec/dataclasses.html#dataclass-transform-parameters

I've created https://github.com/strawberry-graphql/strawberry/pull/3397 for it – I suggest we continue the discussion there, as it's closer to code :)

One step closer to drawing the issue I created to an unfortunately unsatisfying end. The performance hit of this is pretty substantial, see more: https://github.com/strawberry-graphql/strawberry/pull/3397#issuecomment-1965489688

Thanks! > I think that's expected when field aren't optional When you say this, do you mean according to the GraphQL spec or Strawberry's design decision?

Ah, I see it now – thanks! Yeah, the short-circuiting behaviour makes perfect sense :) I tested it in anger in a lot of configurations and every behaviour agreed with...

However, we still have the problem of `on_execute` and `on_operation` hooks completing before resolvers can finish. 😓 We use a custom Strawberry extension for context management. Basically [same as this](https://strawberry.rocks/docs/guides/custom-extensions#execution-context)...