kkmuffme

Results 287 comments of kkmuffme

That's fine, the docs have been wrong all this time. Basically the docs are just missing that a lot of functions may return false if Redis is offline/loading data into...

Also the constants are missing in the stubs and the docs (@todo in https://github.com/phpredis/phpredis#predefined-constants) I just grepped them out of the code base: `Redis::[A-Z_]+` ``` Redis::AFTER Redis::BACKOFF_ALGORITHM_CONSTANT Redis::BACKOFF_ALGORITHM_DECORRELATED_JITTER Redis::BACKOFF_ALGORITHM_DEFAULT Redis::BACKOFF_ALGORITHM_EQUAL_JITTER...

btw the new stubs are amazing, not a PITA at all. In fact I could remove so many static analysis suppressions from the code base and fix a few issues...

I think it should be changed, to only accept string types for set functions (set, mset,...) While technically it is possible to pass mixed (bool, int,...) you will ALWAYS get...

Also this issue should be taken care of https://github.com/phpredis/phpredis/pull/2120 (ideally in the docs too?)

Since this is implemented already, would it be possible to get it merged?

Bump :-) Would really love to get that fixed. Auth can be really expensive especially if the redis master is remote.

I just checked on 4.3.0 and it seems pconnect does not send an "auth", so perhaps it's working already? but not really sure if this isn't a bug in the...

This is wrong for tons of functions. Could you perhaps update them all? https://github.com/phpredis/phpredis/issues/1921

This works already, you can just leave out the unix:// part as this isn't necessary. (same as redis-cli where you can just pass -h /tmp/redis.sock)