Fixes related to building on Windows with CMake, clang-cl, and HAVE_BIN=OFF

[MantisClone]

trafficstars

See commit messages for details. Discussion at #35

[kkm000]

LGTM. @jtrmal, could you please have a look, too?

Tangentially, the problem with missing FST types without whole-archive exists in the original OpenFST, too. I was wondering how the heck it could work at all. Riddle solved, it simply does not. With OpenFST 1.7.9:

$ ./configure --disable-shared --enable-bin
$ make -j $(nproc)
$ cd 
$ echo "0" | src/bin/fstcompile >an.fst
$ src/bin/fstinfo an.fst
ERROR: GenericRegister::GetEntry: vector-fst.so: cannot open shared object file: No such file or directory
ERROR: MutableFst::Read: Unknown FST type "vector" (arc type = "standard"): an.fst

Whoops!

[jtrmal]

ack will do over the weekend y.

On Fri, Nov 20, 2020 at 9:23 AM kkm000 [email protected] wrote:

LGTM. @jtrmal https://github.com/jtrmal, could you please have a look, too?

Tangentially, the problem with missing FST types without whole-archive exists in the original OpenFST, too. I was wondering how the heck it could work at all. Riddle solved, it simply does not. With OpenFST 1.7.9:

$ ./configure --disable-shared --enable-bin $ make -j $(nproc) $ cd $ echo "0" | src/bin/fstcompile >an.fst $ src/bin/fstinfo an.fst ERROR: GenericRegister::GetEntry: vector-fst.so: cannot open shared object file: No such file or directory ERROR: MutableFst::Read: Unknown FST type "vector" (arc type = "standard"): an.fst

Whoops!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kkm000/openfst/pull/36#issuecomment-731199494, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYX6UGRCKKS4SNJV4DWLSQZ3X3ANCNFSM4TX5GX3Q .

[pengzhendong]

Any progress？

[kkm000]

@pengzhendong, very sorry, but both maintainers, I and @jtrmal, are at a final stage of quite a taxing work without a breather. 1-2 weeks.

[pengzhendong]

I'm sorry to bother you, any progress?

[MantisClone]

Any possibility we could merge or close this?

[jtrmal]

I'll put it on my todo. y.

On Wed, Jul 20, 2022 at 7:41 PM MantisClone @.***> wrote:

Any possibility we could merge or close this?

— Reply to this email directly, view it on GitHub https://github.com/kkm000/openfst/pull/36#issuecomment-1190875412, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUKYXY2D5B3R3Q2PIGEBUDVVCFCRANCNFSM4TX5GX3Q . You are receiving this because you were mentioned.Message ID: @.***>

[MantisClone]

I just updated this PR to be in line with the kkm000:winport branch. I'm still hoping we can get it reviewed and merged at some point.

[kkm000]

@MantisClone, thank you for the patch, and apologies for sitting on your PR for a lifetime. Life happens...