Konstantin Klementiev

Results 124 comments of Konstantin Klementiev

what are the main points?

why `entry_points` should be better?

1. We have `scripts` kw in setup.py that copies xrtQookStart.py to Scripts location. It is normally in your PATH, so you don't need the full path, just `xrtQookStart.py`. And this...

>while entry_points are for Python functions I think this speaks _against_ using `entry_points` as we do not export functions but rather scripts as full modules. > As xrtQookStart.py is a...

Hi, If the error is reproducible, I guess this is an incompatibility of OpenGL and numpy. I do not use old versions of WinPython or Anaconda, so I never run...

Hi, I've now done the same: source pitch = 0.3, lens center = [0, 25000, auto], lens pitch = np.pi/2+0.3. And I get this view that looks as expected: The...

>Similarly, if I add a Yaw error to your example, the result looks like the two sides are rotated differently. Yes, this I can see. Thank you for reporting on...

Hi, Before I push it to GitHub, I need more tests. Please replace oes_base.py (but keep the old one for a while) with this one and apply your rotations. [oes_base.zip](https://github.com/kklmn/xrt/files/6542605/oes_base.zip)

Hi, thanks for the tests! Yes, indeed, extra rotations (those after the 3 main rotations) have never been correctly implemented for two-surface optics (also including DCM). Now I've fixed this...

Hi, Please see [this](https://xrt.readthedocs.io/gallery2.html#diamond-filter-of-varying-thickness) example for how to make power plots with power density isolines. Search the examples for `fluxKind='power'` in py files.