Kalin Kiesling
Kalin Kiesling
Everything should be addressed now, so this is ready for review again @GiudGiud @loganharbour
@loganharbour - this should be ready for you to review again and/or respond to discussions. We significantly refined the tests and moved almost everything out into unit tests. @shikhar413 had...
I can't see what the failed job results are for the Controlled apps job on CI ("failed but allowed" it says). But I assume this is the job that is...
Hi @loganharbour, pinging this again so you can take a look at the remain questions and comments, and review again if necessary. Thanks!
@paulromano @matthewfeickert - I have an attempt at adding support for arm64 architectures via conda [here](https://github.com/conda-forge/openmc-feedstock/pull/81). Verdict is still out on whether or not this is will be successful though..
This looks like it will pass CI at this point, so it should be ready for review @GiudGiud
@eshemon FYI
@GiudGiud this should be good to go for another review. I addressed every comment either with a response/explanation or changes. There are also still some outstanding questions I posed in...
I am not entirely sure what happened to the CI here. Looks like it stopped a week ago and just never finished..