Kurt Kartaltepe

Thanks for the PR, FYI we generally recommend larger changes to go through RFCs (https://github.com/obsproject/rfcs) so authors can get feedback before implementing things. Considering pulseaudio is nearly unmaintained in OBS...

> However, I don't know this PR is worth to be merged for now. Especially, I think these points would be the major concerns. > > * No UI is...

> If this is the whole 64bit no, invalid starts with some 0s. If its only the lower bits cut to 32bit, this could be invalid. It is indeed MOD_INVALID...

If you want OBS to even have a prayer at providing you with this kind of information you should request pipewire provide a stronger compatibility guarantee and testing. They report...

Please include a log representative of the error and the full output for `v4l2-ctl --device=/dev/videoXXX --all` for the device in question so we can reference it in the future.

> I'm sorry, there is one more nitpick on the commit message. The first word (`declare`) should be capitalized. I think it would be better to just squash them and...

While reviewing this, the log shows you have enabled the auto-reset feature in the video source, which also isnt the default. does the device still fail to start if you...

I made some minor style changes, and you introduced a merge commit which are not used in OBS remember to rebase instead of pull'ing if you want to update your...

> If so, I think we could solve that by keeping the timeout at 2 seconds until some number of frames were received at which time we would switch to...

> When you talk about not adding more code, do you mean that you don't think this patch should be merged, or do you mean that it is a good...