Konstantin Käfer

This is still an issue that prevents us from running clang-tidy on a full codebase. Here's the clang-tidy 7.0.0 message that I'm getting: ``` /Users/kkaefer/Code/gl/native/vendor/variant/include/mapbox/variant.hpp:504:20: error: The right operand of...

Here's a minimal reproduction: ```cpp #include class Empty {}; inline bool operator==(const Empty&, const Empty&) { return true; } int main() { using type = mapbox::util::variant; type a; type b...

More observations: - adding non-defaulted constructor (`Empty() {}`) makes the UB go away, but adding a defaulted constructor (`Empty() = default`) doesn't

`std::variant` gets away without casts because it uses at its core [a recursively(!) templated union](https://github.com/llvm-mirror/libcxx/blob/57c405955f0abd56f81152ead9e2344b532276ad/include/variant#L615-L649) so that it can write a static accessor that recursively goes through the nested union...

It looks like we're running into https://github.com/Tencent/rapidjson/pull/1533, which is caused by a bug in an old GCC version that we're using.

Sure, all of the math we're using here is only approximate, and we're even assuming that the earth is a sphere rather than an ellipsoid. However, in other parts of...

The earth radius number I'm seeing is `6378137`, which is the one WGS84 is using for equator, not `63781371`.

The value we're using in other parts of our codebase is `6378137`. I tried to find out where `6378160.187` comes from, but couldn't find _any_ other references than Valhalla's source...

bump

I closed https://github.com/mapbox/mapbox-gl-js/pull/6228 because there are still many open questions: - Styles (and thus expressions) are executed on multiple platforms, and JavaScript is just one of them. Regex engines on...