chirp icon indicating copy to clipboard operation
chirp copied to clipboard

Convert to PEP-517

Open vishwin opened this issue 1 year ago • 4 comments

Also use ~~setuptools_scm~~versioningit for dynamic versioning

vishwin avatar May 18 '23 00:05 vishwin

Date-based version automatically set during build when using a full git clone. Otherwise (like git archives for system packaging or shallow clones), supply PKG-INFO:

Version: 20230520

vishwin avatar May 20 '23 01:05 vishwin

I'm not super enthusiastic about these changes (from the community, I appreciate you doing the work here) but alas. Is there some coming deadline with pip or python that makes it important for us to do this right now? Other than the fad aspect I mean :)

Not a fad, but policy, just not enforced until now for some reason.

vishwin avatar May 21 '23 21:05 vishwin

I'm not super enthusiastic about these changes (from the community, I appreciate you doing the work here) but alas. Is there some coming deadline with pip or python that makes it important for us to do this right now? Other than the fad aspect I mean :)

Not a fad, but policy, just not enforced until now for some reason.

The policy is only for things that exist in the python packaging ecosystem and they very definitely don't have the ability to enforce that on us. Just because we're written in python does not mean we need to exist in and abide by all the overly-draconian rules. I'm really only interested in doing as much as is required to avoid making it difficult for people that have to install via pip.

kk7ds avatar May 22 '23 22:05 kk7ds

The policy is only for things that exist in the python packaging ecosystem and they very definitely don't have the ability to enforce that on us. Just because we're written in python does not mean we need to exist in and abide by all the overly-draconian rules. I'm really only interested in doing as much as is required to avoid making it difficult for people that have to install via pip.

As long as you are using any standards-compliant Python package build backend, you are in the Python packaging ecosystem, even if not in PyPI. And in the case of pip, some of us operating systems/distributions cannot use pip for this purpose, but other standards-compliant tooling.

vishwin avatar Aug 11 '24 04:08 vishwin