K.J. Valencik
K.J. Valencik
Thanks again for sharing this issue. I'll re-open since the legacy backend is still supported.
@JonasKruckenberg Thanks for reporting this. Is there a specific reason you would like to see this dependency updated? While it's not properly reporting the dependency in the `package.json`, `iniparser` uses...
In addition, there are a bunch of other feature flags. We should check that all combinations pass `cargo check`.
@rubiagatra Thanks for the offer to contribute! Yes, another pipeline that runs `cargo check` repeatedly with different combinations of feature flags to ensure that all [valid] combinations work. There are...
@deepanshu44 That looks neat! Ideally we would check all permutations of feature flags as well. Using Github Actions matrix building is a cool idea; however, I think it's also worth...
@deepanshu44 That will create all combinations of Node-API versions and each individual feature flag, but not all permutations of feature flags. Some feature flags should probably be removed and made...
+1 to what @Brooooooklyn said about resigning. You can also `rm index.node` prior to re-building. This is a bug (known limitation?) in Apple's code signing cache.
I don't have an M1 mac to test with, but I've been curious if adding an `unlink` step to `cargo-cp-artifact` prior to copying the lib would fix the issue.
Probably something in the `copyArtifact` function. By `unlink`, I mean *delete*. https://nodejs.org/api/fs.html#fspromisesunlinkpath
Oh, yea, I remember investigating it previously. Deleting the file in `cargo-cp-artifact` first works well for cases where it's the final destination (and this should be added if you're interested...