jsrsasign icon indicating copy to clipboard operation
jsrsasign copied to clipboard

Support any attribute OID in DName

Open lionello opened this issue 7 years ago • 5 comments

This patch allows one to add any OID name-value pair in a DName structure.

lionello avatar Oct 30 '16 06:10 lionello

@lionello What is the issue with the current implementation of OID in DName?

Ruffio avatar Jul 25 '17 07:07 Ruffio

@Ruffio The old implementation would throw an exception when an 'unknown' OID was encountered in the DName, 'unknown' meaning an OID that wasn't explicitly hardcoded in jsrsasign. With this patch, unknown OIDs are not converted to strings and simply output as numbers.

lionello avatar Jul 25 '17 10:07 lionello

@lionello Are you missing specific OIDs? Which? I see your point, but I don't know if @kjur wants to open up for this. @kjur ?

Ruffio avatar Jul 25 '17 10:07 Ruffio

It's impossible to add "all" OIDs, since new ones can be created at any time. The library should provide a way to obtain unknown OIDs (these are not invalid, so an exception seems misplaced.)

lionello avatar Jul 25 '17 11:07 lionello

@lionello I see and agree with you. @kjur What do you say?

Ruffio avatar Jul 25 '17 11:07 Ruffio