Kyle Hubert

Can we bump this Issue?

I like this patch. A couple of minor things, when there are inverted cells, this patch shows the original foreground, rather than the inverted foreground. If you compare to Terminal.app,...

Haha, great improvement! Except for two things. 1) If the `cursor-color` is `cell-foreground` then it wipes out the cell's text. If `cursor-color` is `cell-background` then it can't be seen because...

Oh!!! The cursor wiping out the foreground is a problem upstream, it isn't a regression with this patch. I bet most people allow the shell integration for cursors and because...

@cwrau The PR looks like it could match gnome-terminal, but I don't have your precise setup. Here is the best replication I can draw: But again, I'm using `block_hollow` to...

Actually, I stand corrected, with this PR, I can get close to gnome-terminal @cwrau: ``` shell-integration-features = no-cursor cursor-style = block cursor-text = cell-background cursor-style-blink = true cursor-color = cell-foreground...

Anything I can assist with this PR? It would be nice to stop maintaining a private patch.

I will say, my personal patches are reduced after 1.1.0 was released: ```patch diff --git a/src/renderer/Metal.zig b/src/renderer/Metal.zig index 866f9682..7561f1a7 100644 --- a/src/renderer/Metal.zig +++ b/src/renderer/Metal.zig @@ -2635,8 +2635,17 @@ fn rebuildCells(...

Apologies, @mitchellh, I know this is considered closed. Yet, if `cursor-text = cell-foreground` is set, I can see the `cursor-text` looks different. I posted here: https://github.com/ghostty-org/ghostty/pull/5219#issuecomment-2620007145 The function `cell_text_vertex` in...