PHP8 compatibility

[BboyKeen]

Hey kjdev,

As PHP8 is on his way, this extension has to be updated to remove obsolete PHP internals. I'm absolutely not familiar with PHP extension writing so feel free to direct me on something I could have missed, for example about thread safe management.

All tests are green ;)

[kjdev]

Thanks.

---

Not every time, but there were times when I would get an error while testing a few times.

I ran it using php:8.0.0RC2-cli-alpine.

$ make test
$ make test
$ : ..
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
render of option Hoedown::META_BLOCK and parse json [tests/option-meta-block-parse-json.phpt]
=====================================================================

option-meta-block-parse-json.out

Running it on a lower version of PHP also seemed to give me a different error.

> PHP 7.4.11
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
constructor [tests/construct.phpt]
parse of file [tests/parse_file.phpt]
static parse of file [tests/static_parse_file.phpt]
=====================================================================

Even with the master branch, the test fails on PHP 7.4 and so on, so we'll fix that.

[BboyKeen]

You're right. I forgot to mention that. I used php:8.0-RC2 too but this test was skipped, not failed.

Indeed for PHP 7.4. PHP 8 changed the way internals warning were raised so we have two different messages depending on the PHP version. I didn't think about that.

⁣Télécharger BlueMail pour Android ​

Le 23 oct. 2020 à 00:20, à 00:20, kjdev [email protected] a écrit:

Thanks.

---

Not every time, but there were times when I would get an error while testing a few times.

I ran it using php:8.0.0RC2-cli-alpine.

$ make test
$ make test
$ : ..
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
render of option Hoedown::META_BLOCK and parse json
[tests/option-meta-block-parse-json.phpt]
=====================================================================

option-meta-block-parse-json.out

Running it on a lower version of PHP also seemed to give me a different error.

> PHP 7.4.11
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
constructor [tests/construct.phpt]
parse of file [tests/parse_file.phpt]
static parse of file [tests/static_parse_file.phpt]
=====================================================================

Even with the master branch, the test fails on PHP 7.4 and so on, so we'll fix that.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/kjdev/php-ext-hoedown/pull/11#issuecomment-714794346

[kjdev]

tests/option-meta-block-parse-json.phpt error seems to be present in the existing version, so I'll check it as well.