CountryPickerView icon indicating copy to clipboard operation
CountryPickerView copied to clipboard

Improved RTL support (mainly for the UITextField use-case)

Open zfoltin opened this issue 3 years ago • 8 comments

Expose containerView to enable support for layoutMargins and semanticContentAttribute - mainly to improve the UITextField use-case for RTL languages.

Now it's possible to to add some spacing without a 'paddingView' and forceLeftToRight so the flag is on the left in RTL languages - see the sample app for details.

Simulator Screen Shot - iPhone 12 Pro Max - 2021-04-09 at 16 32 57

zfoltin avatar Apr 09 '21 15:04 zfoltin

Hey @kizitonwose any chance you can take a look at this? I'd love to see this released 🙏 🙇

zfoltin avatar May 30 '21 13:05 zfoltin

Hey @kizitonwose any chance you can take a look at this? I'd love to see this released 🙏 🙇

zfoltin avatar Sep 18 '21 11:09 zfoltin

Hello @kizitonwose, I see there has been some activity on this repo recently. Could you please take a look at this PR when you find the time?

zfoltin avatar Dec 31 '21 18:12 zfoltin

Hi @zfoltin , I'll get on it as soon as I find the time, sorry for the delays. You can use your branch with cocoapods as a workaround for now.

kizitonwose avatar Jan 05 '22 18:01 kizitonwose

I want to force my country picker to be LTR when the app in RTL. Is it possible to merge this request or give me a workaround to handle this situation?

MMohamad70 avatar Sep 24 '22 17:09 MMohamad70

@MMohamad70 you can do what @kizitonwose suggests - use the PR's branch in Cocoapods. Something like pod 'CountryPickerView', :git => 'https://github.com/zfoltin/CountryPickerView.git', :branch => 'improved-textfield-support' If this ever gets merged and released 🤞 then I'll delete my fork so keep an eye 👀 on this PR, just in case...

zfoltin avatar Oct 03 '22 17:10 zfoltin

@zfoltin I didn't know I can use it this way. Thanks for your suggestion.

MMohamad70 avatar Oct 04 '22 12:10 MMohamad70

No worries @MMohamad70 👍 I hope @kizitonwose will find the time to review this PR and merge and publish it 🤞

zfoltin avatar Oct 04 '22 12:10 zfoltin