libkiwix icon indicating copy to clipboard operation
libkiwix copied to clipboard

Small kiwix-serve welcome page CSS fix

Open kelson42 opened this issue 3 years ago • 1 comments

Fixes #812

kelson42 avatar Sep 04 '22 15:09 kelson42

@juuz0 @veloman-yunkan How to recompile the resources? It seems to be documented nowhere!

kelson42 avatar Sep 04 '22 15:09 kelson42

@juuz0 @veloman-yunkan How to recompile the resources? It seems to be documented nowhere!

@kelson42 Just modify the resource and build - the resource should be recompiled automatically.

veloman-yunkan avatar Sep 05 '22 07:09 veloman-yunkan

@veloman-yunkan I will check again then. Thx.

kelson42 avatar Sep 05 '22 09:09 kelson42

@veloman-yunkan I have run rm -rf ./build/ && meson . build && ninja -C build && sudo ninja -C build install but then I only get:

$ git status
On branch small-css-fix
Your branch is up to date with 'origin/small-css-fix'.

So something seems wrong somewhere, right?

kelson42 avatar Sep 05 '22 18:09 kelson42

@kelson42 What exactly is wrong? If you expected git status to show the build subdirectory in the list of untracked files, note that it is .gitignored.

veloman-yunkan avatar Sep 06 '22 06:09 veloman-yunkan

Codecov Report

Merging #813 (5e8b977) into master (9f54571) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #813   +/-   ##
=======================================
  Coverage   70.98%   70.98%           
=======================================
  Files          53       53           
  Lines        3736     3736           
  Branches     2086     2078    -8     
=======================================
  Hits         2652     2652           
  Misses       1082     1082           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 06 '22 07:09 codecov[bot]

@kelson42 What exactly is wrong? If you expected git status to show the build subdirectory in the list of untracked files, note that it is .gitignored.

This exactly what is misleading and should be at least documented.

kelson42 avatar Sep 06 '22 08:09 kelson42

@kelson42 What exactly is wrong? If you expected git status to show the build subdirectory in the list of untracked files, note that it is .gitignored.

This exactly what is misleading and should be at least documented.

@kelson42 Any more or less experienced user of git shouldn't be confused by this. I don't think that we have to document the widely used features of our development tools.

veloman-yunkan avatar Sep 06 '22 17:09 veloman-yunkan

The feature of git is quite clear but not all users are familiar with this. More problematic is that files which have to be commited and pushed in many scenarios are put in .gitignore. I understand why this is done that way and I have no better solution in mind. I will do the documentation in an other PR, all of this is Not obvious.

kelson42 avatar Sep 06 '22 17:09 kelson42