libkiwix icon indicating copy to clipboard operation
libkiwix copied to clipboard

[REGRESSION] Kiwix-serve suggestions somehow broken

Open kelson42 opened this issue 3 years ago • 2 comments

With latest libzim/libkiwix/kiwix-tools, the kiwix-serve suggestion does not work anymore. I just need to start the kiwix-serve to get this image

The problem is that the content is not transmited properly, see content=content in the URL. This is clearly a regression.

It seems that under certain conditions the suggestions work again, but I have not been able to identify how exactly.

kelson42 avatar Sep 04 '22 08:09 kelson42

@juuz0 Could you please urgently have a look, I suspect this is somehow a bug which has been introduced at the time jquery has been removed.

kelson42 avatar Sep 04 '22 08:09 kelson42

Acutally it seems:

  • totally broken if article is displayed
  • fully working if fulltext search result is displayed

kelson42 avatar Sep 04 '22 08:09 kelson42

checking it. Although I don't get suggestions either at https://library.kiwix.org/wikipedia_en_all_nopic_2022-01/A/User:The_other_Kiwix_guy/Landing (this is the jquery version of suggestions)

juuz0 avatar Sep 06 '22 07:09 juuz0

@juuz0 Any news why javascript generates url with content in the URL, in place of the human id.

kelson42 avatar Sep 07 '22 15:09 kelson42

@juuz0 Can you please give a feedback here? This is the only blocker left for 12.0.0 milestone and this regression has probably been introduce during the removal pf jquery.

kelson42 avatar Sep 22 '22 07:09 kelson42

@kelson42 I finally got some, working on this now. Though, maybe I need a brief on new changes in this regard: image

which is the correct taskbar (and how do I disable the old one)

juuz0 avatar Sep 23 '22 12:09 juuz0

@juuz0 Browser cache problem? We have now the top bar within an iframe!

kelson42 avatar Sep 23 '22 15:09 kelson42

@kelson42 this seems to be fixed in latest master? (probably after addition of viewer.js)

juuz0 avatar Sep 24 '22 13:09 juuz0

@juuz0 Lucky guy ;) I will check.

kelson42 avatar Sep 24 '22 13:09 kelson42

@juuz0 I confirm that it seems to work now. I guess we have to thank @veloman-yunkan

kelson42 avatar Sep 24 '22 18:09 kelson42