kiwix-js icon indicating copy to clipboard operation
kiwix-js copied to clipboard

Published 20 hours ago • verified publisher icon kiwix

Add option to turn off external link warning in associated dialogue box like Kiwix Android

Open Jaifroid opened this issue 1 year ago • 29 comments

[Originally posted in kiwix/kiwix-js-windows/issues/295, but best to work on here, upstream] Kiwix Android has a little link that allows a user to turn off the dialogue box that warns about external link opening (see screenshot below). We could add something similar to KJS and KJSW. It would be a link that takes the user to the option in Configuration and highlights it (thus educating the user), as we do with with the Active Content Warning.

image

Jaifroid avatar Sep 29 '22 19:09 Jaifroid

I am a beginner and i can try this

dalalvarun avatar Oct 07 '22 13:10 dalalvarun

@dalalvarun Thank you for the offer. Please check https://github.com/kiwix/kiwix-js/blob/master/CONTRIBUTING.md and see if you are comfortable that you can do those things, and also that you have an idea of how you would tackle this PR. Then let us know if you want to be assigned this PR.

Jaifroid avatar Oct 07 '22 13:10 Jaifroid

Yes i think i can do it over a period of few days. Please assign it to me

dalalvarun avatar Oct 07 '22 17:10 dalalvarun