kiwix-js icon indicating copy to clipboard operation
kiwix-js copied to clipboard

Remove unused functions from util.js (possibly also elsewhere)

Open Jaifroid opened this issue 2 years ago • 4 comments

Quite a few functions exported in util.js are unused currently in the app. Some may be interesting techniques that we want to keep for reference, but then we shouldn't expose them. Others are obsolete and should be removed.

Any PR based on this issue should await merging of #838 because some functions are already being removed there.

Jaifroid avatar Feb 20 '22 11:02 Jaifroid

#838 has been merged, it should be easy (my guess) to implememt that one now.

kelson42 avatar May 08 '22 14:05 kelson42

Hello there! I want to resolve this issue. Can someone please guide me for that ?

me-aashish avatar Jun 12 '22 08:06 me-aashish

Hello!

Just to let you know that I am working on this issue given that no PR has been submitted since January.

Bam92 avatar Aug 29 '22 08:08 Bam92

@Bam92 hey there mate, I would like to confirm if you still working on this issue?

dipenr06 avatar Oct 09 '22 02:10 dipenr06

Hey @dipenr06,

Yes, I planned to work on in this hacktoberfest.

Bam92 avatar Oct 17 '22 11:10 Bam92

Don't mind if I do?

dheerajdlalwani avatar Nov 25 '22 22:11 dheerajdlalwani

can I work on this issue?

amitpanwar789 avatar Dec 07 '22 07:12 amitpanwar789

@Bam92 It appears you didn't get a chance to work on this in October, so unless I hear from you, I'll assign it to the next person in the queue who has expressed an interest, @dheerajdlalwani. @amitpanwar789 I'd suggest you choose something else unless @dheerajdlalwani says he's not interested.

Jaifroid avatar Dec 07 '22 07:12 Jaifroid

I have exams going on right now. It will be some time before I can get to it. So in the mean time, i think @amitpanwar789 can go for it?

dheerajdlalwani avatar Dec 07 '22 07:12 dheerajdlalwani

OK, thank you for letting me know @dheerajdlalwani. I'll wait a little to hear from @Bam92, and if he is no longer interested, I'll assign to @amitpanwar789.

Jaifroid avatar Dec 07 '22 07:12 Jaifroid

@Jaifroid Should I wait or start working on it?

amitpanwar789 avatar Dec 08 '22 09:12 amitpanwar789

@amitpanwar789 You can go ahead, thanks!

Jaifroid avatar Dec 08 '22 10:12 Jaifroid

@Jaifroid should I remove those unused functions completely from the util.js or just remove them only from return(export)?

amitpanwar789 avatar Dec 08 '22 11:12 amitpanwar789

@amitpanwar789 You should remove them completely, please. They will remain in the git history in case anyone ever needs to find them again.

Jaifroid avatar Dec 08 '22 11:12 Jaifroid