kiwix-js icon indicating copy to clipboard operation
kiwix-js copied to clipboard

Recent stackexchange ZIM files have broken responsive design in jQuery mode

Open mossroy opened this issue 2 years ago • 3 comments

https://mirror.download.kiwix.org/zim/.hidden/dev/alcohol_meta_stackexchange_com_2021-08.zim has a responsive design : the Questions/Tags/Users/About items that appear on the left side on large screens should be moved at the top on smaller screens :

  • With a large window/screen, the header looks like this : image

  • With a smaller window/screen ((width<=640px), it should look like this : image

In ServiceWorker mode, it works fine (even if I find the difference surprising, see https://github.com/openzim/sotoki/issues/237) But in jQuery mode, the left panel remains in small screens : image

I initially thought it was because of some javascript handling (unsupported in jQuery mode), but @rgaudin says javascript is not used for that (see https://github.com/openzim/sotoki/issues/237#issuecomment-903233613)

We should investigate to see where it comes from. If it's something we can't easily fix in kiwix-js, it might be still time to ask for a change on sotoki (if it's not complicated).

mossroy avatar Aug 22 '21 17:08 mossroy

I wonder if this has anything to do with the order in which CSS is loaded and applied. Very wild guess.

Jaifroid avatar Aug 23 '21 05:08 Jaifroid

We finally are refreshing all StackExchange ZIM files (180 of them) with version 2.0.0 of Sotoki. Therefore, from now, this bug will have more impact.

kelson42 avatar May 08 '22 14:05 kelson42

I confirm this issue is still present (jQuery mode only) in Stack Exchange ZIMs produced this month (yesterday). I tested with french_stackexchange_com_2022-05.zim. The issue seems to come from the fact that the the inner divs do not in fact resize when the page as a whole is resized. The same issue affects KJSW (in jQuery mode only).

image

Jaifroid avatar May 09 '22 08:05 Jaifroid

Bug is still there in 3.6.0 with beer.stackexchange.com_en_all_2022-11.zim, but really wonder this is worth investigating considering that SW mode is default one and we priority is not anymore to fix bugs in JQuery mode.

kelson42 avatar Nov 13 '22 15:11 kelson42

I confirm. It's clearly not a problem with the ZIM, because it affects only jQuery mode. I agree it's not worth fixing for JQuery mode only. This is therefore very low priority. I'll close it as wontfix.

Jaifroid avatar Nov 13 '22 15:11 Jaifroid

I agree

mossroy avatar Nov 13 '22 18:11 mossroy