kiwix-js icon indicating copy to clipboard operation
kiwix-js copied to clipboard

Test compiling zstddec or xzdec (wasm and asm versions) with MINIMAL_RUNTIME

Open Jaifroid opened this issue 2 years ago • 2 comments

This would be to eliminate the warning shown in console about a streaming WASM compilation error. Although the current implementaiton provides a fallback to ArrayBuffer instnatiation, it would be good to avoid the warning if we can, by setting the appropriate Emscripten flags at compile time.

For further details, see discussion here:

https://github.com/kiwix/kiwix-js/pull/740#issuecomment-885163078

and here:

https://github.com/kiwix/kiwix-js/pull/740#issuecomment-886094851

Jaifroid avatar Jul 31 '21 16:07 Jaifroid

@mossroy @Jaifroid Does this ticket still makes sense considering that we are following the emscripten road?

kelson42 avatar Jun 26 '22 11:06 kelson42

@kelson42 I would say this should be kept until we are sure that we can use the libzim version in most modern contexts. There are still some issues to resolve with that, albeit @mossroy has resolved the major blocker.

Jaifroid avatar Jun 26 '22 11:06 Jaifroid

@Jaifroid I guess we can now close this then?

kelson42 avatar Jan 09 '23 17:01 kelson42

Yes, I don't think realistically we're going to be recompiling XZ or ZSTD given that the versions we have work fine with old browsers and don't cause any issues. We can close now.

Jaifroid avatar Jan 09 '23 17:01 Jaifroid