kiwix-js icon indicating copy to clipboard operation
kiwix-js copied to clipboard

Published 20 hours ago • verified publisher icon kiwix

Complete the renaming of 'title' to 'url' or 'path' according to context

Open Jaifroid opened this issue 3 years ago • 2 comments

When merged #709 will rename getDirEntryByTitle to getDirEntryByPath to avoid the confusion mentioned in https://github.com/kiwix/kiwix-js/pull/709#discussion_r587718534. Some of the associated usage of 'title' where url or pathname is meant is cleaned up by that PR where a function directly used the old getDirEntryByTitle. However, there is still lots of ambiguous usage of 'title' throughout the code, and this needs to be cleaned up more thoroughly by a separate PR.

Jaifroid avatar Mar 04 '21 21:03 Jaifroid

Hi Jaifroid,

Are you still working on this issue or do you need any help?

Bam92 avatar May 11 '21 06:05 Bam92

@Bam92 Thank you for the offer. If you want to take a look, please do. Just make sure you are able to test thoroughly any changes you make on at least Firefox, Chrome and IE11 (we have users with old equipment in developing countries). Sometimes 'title' will need to be changed to 'url', and sometimes to 'path', according to context.

Jaifroid avatar May 11 '21 09:05 Jaifroid