kiwix-desktop icon indicating copy to clipboard operation
kiwix-desktop copied to clipboard

Zim files requiring Service Workers should be hidden from the library if SW are not available

Open Popolechien opened this issue 2 years ago • 9 comments

Following up on Libkiwix#696

Currently zimit-generated files can only be read on Kiwix-Android and Kiwix-serve (K-Desktop has a workaround but it's not main stuff). Kiwix-desktop cannot read these files at the moment, yet it is likely that at least some users will invest data transfers (and costs) into downloading files they ultimately cannot access.

Since zimit-generated files are tagged as such, it would make sense that they be hidden from the app's internal library if we know it cannot be read.

Popolechien avatar Feb 01 '22 10:02 Popolechien

Actually this is a bit more subtil IMO because these files are perfectly usable with the server feature. I would instread recommend to build a message explaining that they should use the server for the time being the feature is still not fully implemented in the rich application.

kelson42 avatar Feb 14 '22 19:02 kelson42

I strongly disagree. This complexifies the products as most users are unable / unwilling to read notices. This will marginally alleviate the current level of frustration.

Popolechien avatar Feb 14 '22 19:02 Popolechien

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 13 '22 03:06 stale[bot]

I would suggest you have an option in the UI: "Allow download of Zimit-based archives (for expert users)". If a user turns this on, they get a message explaining that they will need to serve the file to a browser. This will put off naive users, but not frustrate expert users.

JFYI, there is reasonable click-and-play support for Zimit ZIMs now in Kiwix JS Windows/Linux, including the PWA (but not in the browser extensions).

Jaifroid avatar Aug 10 '22 15:08 Jaifroid

Indeed, the implementation of Zimit ZIM files keeps being postponed... we should really implement this quickly, this is a super easy fix. Doe someone knows how to filter out the ZIM with _sw tag with an OPDS API request?

@juuz0 Maybe you know the answer to that question?

kelson42 avatar Aug 11 '22 08:08 kelson42

@kelson42 Though I don't know about any such OPDS API request, it is easy to hide based on if the book has a _sw tag or not. And should there be a Settings option as Jailfroid suggests?

juuz0 avatar Aug 11 '22 15:08 juuz0

@juuz0 Great, then If I understand you right you coukd do easily a PR? Considering that the prio is to implement support of SW base ZIM, i don't think we need a setting.

kelson42 avatar Aug 11 '22 16:08 kelson42

It's up to you @kelson42 , but I'm sure you'll have to deal with enquiries from users who will say "why can't I find my Zimit files in the app any more?".... Of course they can get them from library.kiwix.org, so it's no great loss I guess.

Jaifroid avatar Aug 11 '22 16:08 Jaifroid

@Jaifroid I prefer this than complains that it does not work. Hopefully within a few months the support will be introduced anyway.

kelson42 avatar Aug 11 '22 16:08 kelson42