kiwix-desktop icon indicating copy to clipboard operation
kiwix-desktop copied to clipboard

Open background (and new) tabs in expanded view

Open alex-ie opened this issue 2 years ago • 7 comments

New tab opens in background (by middle clicking on link) in collapsed view. That way search in page cannot find info in collapsed sections and reader need to expand sections to view. I don't see reason (what was it?) to open background tabs in collapsed and open topics from search in expanded; browsers (e.g. Firefox) open background tabs in expanded. Could background be opened in expanded view by default (if not please give user a choice somewhere in options or right-click menu list both)? Added: I noted right-clicking and choosing "Open in new tab" also opens collapsed (difference from background it switches to that tab), so IMHO expanded would be better here too for same reasons.

alex-ie avatar Sep 06 '21 06:09 alex-ie

What do you means by "expanded" ? If you are speaking about the section inside the page itself, kiwix-desktop does nothing about this.

On some zim files (tested on two years old mathematics wikipedia) sections are not expanded. On others (recent mathematics wiki), sections are expanded. It is probably a content issue. What zim files are you using ?

mgautierfr avatar Sep 07 '21 09:09 mgautierfr

@mgautierfr Behavior depends on whether link is just clicked (or opened from search, or opened via "Open in new tab" right-click menu - all results in new tab on foreground), or opened via middle button of mouse (tab is opened in background - to the right, focus remains on original tab).

This paragraph explains just-in-case what I mean by "expanded". E..g Wikipedia english max, search for "Human eye" then Enter -> "Human eye" page is opened, all sections (with triangles on the left) inside page are expanded (e.g. first one "Structure" and triangle points down). If open "Light" page and from there middle-click on "Human eye", tab will open to the right and "Structure" section collapsed (triangle points to the right). So Kiwix opens same pages differently.

This issue (of opening collapsed) might become more important if changes would be done in https://github.com/kiwix/kiwix-desktop/issues/637 ( Open new tab in background #637 ) as (per my understanding) @kelson42 seems more appropriate, that is "Open in new tab" right-click menu would open background too.

alex-ie avatar Sep 08 '21 16:09 alex-ie

@kelson42, hi. Thanks for doing https://github.com/kiwix/kiwix-desktop/issues/703, your initial concern for it was "I don't think this is how works Chrome or Firefox, right? They both are our refereneces regarding this kind of shortcut.". On this issue, when I open a link to wikipedia in FF (e.g. from Google search) it always opens fully expanded. As just another problem with collapsed view I noted links within the wiki page do not work if a link points to collapsed section.

alex-ie avatar Oct 21 '21 02:10 alex-ie

All of this has nothing to do with Kiwix Desktop I believe. This is as well a Wikipedia/Wikisource/… specific topic. If the sections are open or not at start depends on the availalble width to display. If you are on a PC, you should have enough width, therefore always open at start. This is completly independent of load in background or not I believe. But it seems true that this behaviour is not always correct. It will need further investigation.

kelson42 avatar Oct 31 '21 06:10 kelson42

Recently noted an interesting hack: wiki page opened collapsed except for 1st section. I can open other page in that tab (e..g. click some link, or do search), then go back and voala - page is opened with all sections expanded! Opening other page changes "property" of the tab to open all expanded. @kelson42, how did you notice expand/collapse depend on width?

alex-ie avatar Nov 15 '21 00:11 alex-ie

@MananJethwani By fixing the sections in MWofféiner we should as well look at this ticket probably.

kelson42 avatar Nov 15 '21 08:11 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Aug 14 '22 01:08 stale[bot]