kiwix-desktop icon indicating copy to clipboard operation
kiwix-desktop copied to clipboard

Published 20 hours ago • verified publisher icon kiwix

Reorder header includes properly

Open kelson42 opened this issue 3 years ago • 1 comments

https://github.com/kiwix/kiwix-desktop/pull/616#issuecomment-802741973

kelson42 avatar Apr 08 '21 12:04 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 09 '21 01:06 stale[bot]

@kelson42 please correct me if I am wrong, but after a quick check I think that currently the only file not including its header first is urlschemehandler.cpp, which first includes kiwixapp.h and urlschemehandler.h second.

Is this the only one that has been left?

sgourdas avatar Apr 08 '24 08:04 sgourdas

@sgourdas I guess @mgautierfr is the right person to answer you but would recommend to try a PR and see comments then.

kelson42 avatar Apr 08 '24 12:04 kelson42