kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

[Bug] Search function with widget do not work properly in specific case.

Open JunsuLime opened this issue 6 years ago • 12 comments

Bug Report

Are you ready to report?

Yes 👍  

Environment

  • version of the software you use : version name 2.3 (2018-03-12 master branch)
  • device / operating system : Samsung Galaxy S8, Huawei Honor A6

The Bug:

bug_report

In specific case when I use widget search, It does not go to search screen, goes to latest wiki page.

Steps to reproduce:

  1. Click widget's "search kiwix" button
  2. Then search screen will be appear. Press back press button to go to latest wiki page
  3. In latest wiki page, Press home button, go to home.
  4. At home, click widget's "search kiwix" button again.
  5. We'll see latest wiki page, not search screen.

If It work properly, at step 5 we can see search screen. But this case, It does not appear.

I would like to work this issue.

JunsuLime avatar Mar 12 '18 11:03 JunsuLime

@mhutti1 I think it is a good idea to hide the FIND IN PAGE button when a search is triggered this way. It seems unnatural and doesn't make any sense there. What do you think?

sakchhams avatar Mar 19 '18 18:03 sakchhams

@soloturn @mhutti1 can i work on this.

prajurock avatar Feb 27 '19 19:02 prajurock

@prajurock There is a PR already opened for this issue. Can you try rebasing the same?

abdulwd avatar Feb 28 '19 13:02 abdulwd

ok @abdulwd but unknown repository is showing in his branch. I dont know how to do that please HELP

prajurock avatar Mar 02 '19 21:03 prajurock

You can open a new PR then.

abdulwd avatar Mar 03 '19 05:03 abdulwd

@abdulwd can i work on this?

Afleh avatar Mar 14 '19 02:03 Afleh

@Afleh A pull request is already there for this issue.

abdulwd avatar Mar 14 '19 04:03 abdulwd

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Aug 14 '19 05:08 stale[bot]

@abdulwd @macgills @JunsuLime Might that be that this bug has been fixed and we have forgotten to close it?

kelson42 avatar Feb 04 '20 11:02 kelson42

I would say it could still be bugged

macgills avatar Feb 04 '20 11:02 macgills

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Apr 04 '20 11:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Oct 17 '20 02:10 stale[bot]