kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Give user an option to increase or decrease text size of the article.

Open harshvardhan-takawale opened this issue 7 years ago • 10 comments

Is it a ? Feature Request

Feature Request

Feature Description

User can be given some option to change the text size (predefined options) of the Wikipedia article

Are you willing to work on the issue?

Yes.

harshvardhan-takawale avatar Feb 16 '18 10:02 harshvardhan-takawale

@harshvardhan-takawale Pinch zoom is already there. I don't think it's necessary.

arpank10 avatar Feb 16 '18 11:02 arpank10

@harshvardhan-takawale There is already a zoom option in the settings.

kelson42 avatar Feb 16 '18 11:02 kelson42

@kelson42 @arpank10 @mhutti1 Reading is really very tough when you use zoom option, you have to scroll vertically as well as horizontally. If we add this feature it would be really helpful to the user as they just have to scroll vertically, the text would automatically adjust.

harshvardhan-takawale avatar Feb 16 '18 11:02 harshvardhan-takawale

@kelson42 @mhutti1 Something of this kind (sorry for bad video quality) -

textsize

harshvardhan-takawale avatar Feb 17 '18 04:02 harshvardhan-takawale

If you want to try to try to implement this without too much overhead then you can try to and we will see how it works out.

mhutti1 avatar Feb 17 '18 21:02 mhutti1

@mhutti1 @kelson42 @rashiq This is how it can be implemented (I'll change the seekbar location) kiwixtext

harshvardhan-takawale avatar Feb 18 '18 05:02 harshvardhan-takawale

@harshvardhan-takawale With the zoom level in the settings, the whole text is wrapped properly, you should not have to scroll horizontally. This is at least not the behaviour I have on my devices.

kelson42 avatar Feb 18 '18 09:02 kelson42

@kelson42 Well that doesn't happen on my device (Moto G4 plus). Also when I change it back to original size, the text gets skewed. Should I make a PR for the feature? 20180218_161345

harshvardhan-takawale avatar Feb 18 '18 10:02 harshvardhan-takawale

@harshvardhan-takawale Yes, please go ahead like @mhutti1 invited you to do.

kelson42 avatar Feb 18 '18 11:02 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 26 '19 06:06 stale[bot]