kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Fixed: Not able to open a ZIM file from Samsung's file explorer.

Open MohitMaliFtechiz opened this issue 1 year ago • 1 comments

Fixes #4002

MohitMaliFtechiz avatar Oct 08 '24 13:10 MohitMaliFtechiz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.01%. Comparing base (7400c26) to head (0eb618c). Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4022      +/-   ##
============================================
- Coverage     58.04%   58.01%   -0.04%     
+ Complexity     1517     1514       -3     
============================================
  Files           315      315              
  Lines         13125    13125              
  Branches       1671     1671              
============================================
- Hits           7619     7614       -5     
+ Misses         4412     4406       -6     
- Partials       1094     1105      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '24 13:10 codecov[bot]

Please split the part about handling of files which are not proper ZIM files in a dedicated PR. Explain clearly what is the behaviour.

AFAIK this is not that easy because you can not always do it as you need first to move/copy the fikes to app directory first. When error, you should rollback this.

kelson42 avatar Oct 29 '24 11:10 kelson42