kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Localisation updates from https://translatewiki.net.

Open translatewiki opened this issue 1 year ago • 5 comments

Translation updates

translatewiki avatar Feb 08 '24 12:02 translatewiki

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (30c9e7b) 51.92% compared to head (37d1003) 51.88%. Report is 3 commits behind head on main.

:exclamation: Current head 37d1003 differs from pull request most recent head ebdc544. Consider uploading reports for the commit ebdc544 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3697      +/-   ##
============================================
- Coverage     51.92%   51.88%   -0.04%     
+ Complexity     1237     1234       -3     
============================================
  Files           290      290              
  Lines         10955    10955              
  Branches       1470     1470              
============================================
- Hits           5688     5684       -4     
- Misses         4302     4303       +1     
- Partials        965      968       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 08 '24 13:02 codecov[bot]

@kelson42 I have reviewed the PR, most of the TypographyQuotes error is fixed only a few are left to come. Apart from this, lint is failing since in new translations there is an argument error made by the translator which made the application crash if in this language application runs. I have placed a fix on the upstream for this issue and a another issue. Hope the new changes will come soon.

[StringFormatMatches]
            instance.toast(instance.getString(R.string.save_media_saved, it.name)).also {

MohitMaliFtechiz avatar Feb 09 '24 11:02 MohitMaliFtechiz

Lets wait 2-3 days then.

kelson42 avatar Feb 09 '24 11:02 kelson42

@MohitMaliFtechiz Status here?

kelson42 avatar Feb 14 '24 06:02 kelson42

@kelson42 Many new translations files came in this PR with lint issues. And we are also facing TypographyQuotes error in https://github.com/kiwix/kiwix-android/issues/3555. We have fixed all the lint and TypographyQuotes errors on the upstream. However, lint is still failing because new changes have not come in this PR. Once they came the lint issue will be fixed.

MohitMaliFtechiz avatar Feb 14 '24 10:02 MohitMaliFtechiz