kiwix-android
kiwix-android copied to clipboard
Fix Initial download doesn't happen
Fixes: #3080
Codecov Report
Base: 45.07% // Head: 49.46% // Increases project coverage by +4.38%
:tada:
Coverage data is based on head (
58199f7
) compared to base (d7b15a3
). Patch coverage: 45.45% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## develop #3084 +/- ##
=============================================
+ Coverage 45.07% 49.46% +4.38%
Complexity 25 25
=============================================
Files 299 299
Lines 9502 9510 +8
Branches 977 977
=============================================
+ Hits 4283 4704 +421
+ Misses 4806 4350 -456
- Partials 413 456 +43
Impacted Files | Coverage Δ | |
---|---|---|
...wix/kiwixmobile/core/utils/SharedPreferenceUtil.kt | 59.77% <ø> (+4.59%) |
:arrow_up: |
...e/nav/destination/library/OnlineLibraryFragment.kt | 33.19% <45.45%> (+7.34%) |
:arrow_up: |
...elper/ScrollingViewWithBottomNavigationBehavior.kt | 65.00% <0.00%> (-20.00%) |
:arrow_down: |
...org/kiwix/kiwixmobile/intro/CustomPageIndicator.kt | 80.00% <0.00%> (-0.25%) |
:arrow_down: |
.../kiwixmobile/core/dao/entities/BookOnDiskEntity.kt | 94.73% <0.00%> (ø) |
|
...rg/kiwix/kiwixmobile/core/search/SearchFragment.kt | 61.79% <0.00%> (+1.12%) |
:arrow_up: |
...le/nav/destination/library/LocalLibraryFragment.kt | 47.36% <0.00%> (+1.16%) |
:arrow_up: |
...kiwix/kiwixmobile/zimManager/ZimManageViewModel.kt | 88.41% <0.00%> (+1.54%) |
:arrow_up: |
...java/org/kiwix/kiwixmobile/core/data/Repository.kt | 42.59% <0.00%> (+1.85%) |
:arrow_up: |
...kiwixmobile/core/utils/dialog/RateDialogHandler.kt | 25.64% <0.00%> (+2.56%) |
:arrow_up: |
... and 31 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@MohitMaliFtechiz It also fails on android 30.
@MohitMaliFtechiz It also fails on android 30.
hi @gouri-panda I just rerun it and its green now.
We should add tests as well.
Hi @gouri-panda , i have added test case for this scenario, now it's ready for review.