Fix Storage permission on Android 13

[MohitMaliFtechiz]

Fixes #3081

[kelson42]

@MohitMaliDeveloper CI seems to fail :(

[codecov[bot]]

Codecov Report

Base: 48.48% // Head: 48.57% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (89e923e) compared to base (a0449ef). Patch coverage: 9.09% of modified lines in pull request are covered.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #3082      +/-   ##
=============================================
+ Coverage      48.48%   48.57%   +0.08%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9723     9726       +3     
  Branches        1177     1187      +10     
=============================================
+ Hits            4714     4724      +10     
+ Misses          4464     4455       -9     
- Partials         545      547       +2     

Impacted Files	Coverage Δ
...le/nav/destination/library/LocalLibraryFragment.kt	50.61% <0.00%> (+2.94%)	:arrow_up:
...a/org/kiwix/kiwixmobile/core/main/AddNoteDialog.kt	0.00% <0.00%> (ø)
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt	30.42% <0.00%> (-0.07%)	:arrow_down:
...wix/kiwixmobile/core/settings/CorePrefsFragment.kt	46.77% <0.00%> (-0.51%)	:arrow_down:
...ix/kiwixmobile/custom/main/CustomReaderFragment.kt	0.00% <0.00%> (ø)
...e/nav/destination/library/OnlineLibraryFragment.kt	32.79% <7.69%> (-0.41%)	:arrow_down:
...wix/kiwixmobile/core/utils/SharedPreferenceUtil.kt	59.34% <25.00%> (-0.89%)	:arrow_down:
...rg/kiwix/kiwixmobile/core/utils/files/FileUtils.kt	25.65% <33.33%> (-0.14%)	:arrow_down:
...rg/kiwix/kiwixmobile/core/search/SearchFragment.kt	64.04% <0.00%> (+2.24%)	:arrow_up:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[MohitMaliFtechiz]

@MohitMaliDeveloper CI seems to fail :(

hi @kelson42 , I just rerun it and its green now.

[kelson42]

Hi @gouri-panda I think this PR desserves a new review.

[gouri-panda]

@kelson42 It would be best if we do this after #2944 and also it would be best if we add tests for this in the PR as well.

[MohitMaliFtechiz]

@kelson42 It would be best if we do this after #2944 and also it would be best if we add tests for this in the PR as well.

hi @gouri-panda ,

Actually we are not taking storage permission on android 13 because we are saving zim files inside app specific directory and for test case i think #3084 in this PR we added InitialDownloadTest will works for this issue.

According to https://github.com/kiwix/kiwix-android/issues/3081#issue-1377421856 after clicking on download button it's showing a dialog, so for this issue our InitialDownloadTest will works.

[kelson42]

@gouri-panda not sure aaut the status here hobenestly!

[kelson42]

@gouri-panda ???

[gouri-panda]

@MohitMaliDeveloper There are some conflict files here :)

[MohitMaliFtechiz]

@MohitMaliDeveloper There are some conflict files here :)

hi @gouri-panda , i have resolved the conflicts.

[gouri-panda]

@MohitMaliDeveloper Thanks!

[kelson42]

@gouri-panda Still good for you to merge?

[gouri-panda]

Ok @kelson42 . Let me review again!