kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Convert KiwixSplashActivityTest.java into kotlin

Open MohitMaliFtechiz opened this issue 3 years ago • 1 comments

Fixes: #3048 Parent Issue: #1826

Converted KiwixSplashActivityTest.java into kotlin

MohitMaliFtechiz avatar Sep 05 '22 08:09 MohitMaliFtechiz

Codecov Report

Base: 48.95% // Head: 48.56% // Decreases project coverage by -0.38% :warning:

Coverage data is based on head (a7ddaf0) compared to base (0c30487). Patch has no changes to coverable lines.

:exclamation: Current head a7ddaf0 differs from pull request most recent head 39eca98. Consider uploading reports for the commit 39eca98 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3049      +/-   ##
=============================================
- Coverage      48.95%   48.56%   -0.39%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9583     9583              
  Branches        1028     1028              
=============================================
- Hits            4691     4654      -37     
- Misses          4415     4456      +41     
+ Partials         477      473       -4     
Impacted Files Coverage Δ
...kiwix/kiwixmobile/core/downloader/model/Seconds.kt 0.00% <0.00%> (-40.91%) :arrow_down:
...org/kiwix/kiwixmobile/intro/CustomPageIndicator.kt 69.62% <0.00%> (-9.39%) :arrow_down:
...ix/kiwixmobile/core/utils/dialog/RateAppCounter.kt 58.33% <0.00%> (-8.34%) :arrow_down:
.../kiwixmobile/core/downloader/model/DownloadItem.kt 20.00% <0.00%> (-4.45%) :arrow_down:
...kiwix/kiwixmobile/zimManager/ZimManageViewModel.kt 85.71% <0.00%> (-2.71%) :arrow_down:
...kiwixmobile/core/utils/dialog/RateDialogHandler.kt 23.07% <0.00%> (-2.57%) :arrow_down:
...le/nav/destination/library/LocalLibraryFragment.kt 46.19% <0.00%> (-1.17%) :arrow_down:
...iwix/kiwixmobile/core/main/CoreReaderFragment.java 34.91% <0.00%> (-0.26%) :arrow_down:
.../org/kiwix/kiwixmobile/core/main/DocumentParser.kt 96.00% <0.00%> (+28.00%) :arrow_up:
.../kiwix/kiwixmobile/core/main/TableDrawerAdapter.kt 87.23% <0.00%> (+38.29%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 05 '22 09:09 codecov[bot]

@MohitMaliDeveloper Still it is failing on the physical device but I haven't tested it on emulated device. I think it's still the same.

hi @gouri-panda

can you please tell which device you use, i have tested on emulator as well as on real device and all test are passed.

MohitMaliFtechiz avatar Oct 14 '22 12:10 MohitMaliFtechiz

@MohitMaliDeveloper Device Realme and the version is 11. Let me know if you need anything.

gouri-panda avatar Oct 16 '22 22:10 gouri-panda