kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Convert SettingsContract.java to kotlin

Open MohitMaliFtechiz opened this issue 3 years ago • 1 comments

Fixes: #3019 Parent Issue: #1826

Converted SettingsContract.java to kotlin

MohitMaliFtechiz avatar Sep 01 '22 13:09 MohitMaliFtechiz

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]

@gouri-panda Could you please review that one? Seems trivial.

kelson42 avatar Oct 11 '22 10:10 kelson42

@kelson42 Sure!

gouri-panda avatar Oct 11 '22 11:10 gouri-panda

Codecov Report

Base: 49.50% // Head: 48.98% // Decreases project coverage by -0.51% :warning:

Coverage data is based on head (58d2337) compared to base (9437f62). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3020      +/-   ##
=============================================
- Coverage      49.50%   48.98%   -0.52%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9512     9529      +17     
  Branches         978      990      +12     
=============================================
- Hits            4709     4668      -41     
- Misses          4349     4408      +59     
+ Partials         454      453       -1     
Impacted Files Coverage Δ
...va/org/kiwix/kiwixmobile/main/KiwixMainActivity.kt 63.63% <0.00%> (-16.70%) :arrow_down:
.../org/kiwix/kiwixmobile/core/utils/LanguageUtils.kt 32.00% <0.00%> (-0.33%) :arrow_down:
.../kiwixmobile/core/utils/ZimReaderContainerUtils.kt 0.00% <0.00%> (-50.00%) :arrow_down:
.../kiwix/kiwixmobile/core/main/TableDrawerAdapter.kt 48.93% <0.00%> (-38.30%) :arrow_down:
...iwix/kiwixmobile/core/main/KiwixWebChromeClient.kt 66.66% <0.00%> (-33.34%) :arrow_down:
.../org/kiwix/kiwixmobile/core/main/DocumentParser.kt 68.00% <0.00%> (-28.00%) :arrow_down:
...obile/core/page/history/adapter/HistoryListItem.kt 46.34% <0.00%> (-24.40%) :arrow_down:
...wix/kiwixmobile/core/main/MainRepositoryActions.kt 11.11% <0.00%> (-16.67%) :arrow_down:
...bile/nav/destination/reader/KiwixReaderFragment.kt 47.94% <0.00%> (-4.11%) :arrow_down:
...java/org/kiwix/kiwixmobile/core/data/Repository.kt 38.88% <0.00%> (-3.71%) :arrow_down:
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 11 '22 12:10 codecov[bot]