kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Convert BookmarksSpec.java into kotlin

Open MohitMaliFtechiz opened this issue 2 years ago • 2 comments

Fixes: #2999 Parent Issue: #1826

Converted BookmarksSpec.java into kotlin

MohitMaliFtechiz avatar Aug 31 '22 10:08 MohitMaliFtechiz

Codecov Report

Base: 48.46% // Head: 48.26% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (569a09a) compared to base (82d7993). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3000      +/-   ##
=============================================
- Coverage      48.46%   48.26%   -0.20%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9717     9722       +5     
  Branches        1173     1173              
=============================================
- Hits            4709     4692      -17     
- Misses          4469     4488      +19     
- Partials         539      542       +3     
Impacted Files Coverage Δ
...iwixmobile/core/data/local/entity/BookmarksSpec.kt 0.00% <0.00%> (ø)
.../kiwixmobile/core/downloader/model/DownloadItem.kt 22.22% <0.00%> (-11.12%) :arrow_down:
...kiwix/kiwixmobile/zimManager/ZimManageViewModel.kt 85.27% <0.00%> (-2.72%) :arrow_down:
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 54.37% <0.00%> (-1.88%) :arrow_down:
...org/kiwix/kiwixmobile/intro/CustomPageIndicator.kt 79.75% <0.00%> (-0.50%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 07 '22 09:09 codecov[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]

What is the status here?

kelson42 avatar Nov 02 '22 06:11 kelson42

@gouri-panda @MohitMaliDeveloper CI fails twice, I can not merge it.

kelson42 avatar Nov 02 '22 08:11 kelson42

@gouri-panda @MohitMaliDeveloper CI fails twice, I can not merge it.

hi @kelson42 , CI should be green after https://github.com/kiwix/kiwix-android/pull/3124.

MohitMaliFtechiz avatar Nov 02 '22 08:11 MohitMaliFtechiz