kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Introduce android 13 CI in project

Open MohitMaliFtechiz opened this issue 2 years ago • 8 comments

Fixes #2918

MohitMaliFtechiz avatar Aug 10 '22 09:08 MohitMaliFtechiz

Codecov Report

Base: 48.62% // Head: 48.48% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (a0449ef) compared to base (21c6a27). Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2944      +/-   ##
=============================================
- Coverage      48.62%   48.48%   -0.15%     
  Complexity        25       25              
=============================================
  Files            299      299              
  Lines           9723     9723              
  Branches        1177     1177              
=============================================
- Hits            4728     4714      -14     
- Misses          4453     4464      +11     
- Partials         542      545       +3     
Impacted Files Coverage Δ
.../kiwixmobile/core/downloader/model/DownloadItem.kt 22.22% <0.00%> (-11.12%) :arrow_down:
...kiwix/kiwixmobile/zimManager/ZimManageViewModel.kt 85.27% <0.00%> (-2.72%) :arrow_down:
...rg/kiwix/kiwixmobile/core/search/SearchFragment.kt 61.79% <0.00%> (-2.25%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 10 '22 10:08 codecov[bot]

@MohitMaliDeveloper What is the status here?

kelson42 avatar Aug 23 '22 16:08 kelson42

@MohitMaliDeveloper What is the status here?

hi @kelson42 ,

Well the PR is almost done , new android 13 CI is being added only thing is left is test failure and i believe after fixing this https://github.com/kiwix/kiwix-android/issues/2956 it will auto resolved.

MohitMaliFtechiz avatar Aug 24 '22 12:08 MohitMaliFtechiz

Well the PR is almost done , new android 13 CI is being added only thing is left is test failure and i believe after fixing this https://github.com/kiwix/kiwix-android/issues/2956 it will auto resolved.

@MohitMaliFtechiz Should i fix #2956 now?

gouri-panda avatar Aug 25 '22 13:08 gouri-panda

Well the PR is almost done , new android 13 CI is being added only thing is left is test failure and i believe after fixing this #2956 it will auto resolved.

@MohitMaliFtechiz Should i fix #2956 now?

yes go ahead.

MohitMaliFtechiz avatar Aug 25 '22 13:08 MohitMaliFtechiz

@MohitMaliFtechiz What is the status here. Could you finish this PR or do we have another blocker?

kelson42 avatar Sep 05 '22 15:09 kelson42

We should merge this after #2967

gouri-panda avatar Sep 06 '22 09:09 gouri-panda

I just merged #2967, this PR shoukd be rebased and completed.

kelson42 avatar Sep 06 '22 17:09 kelson42

@MohitMaliFtechiz @gouri-panda So, we are good to review here? No regtession in stability of CI foreseen?

kelson42 avatar Sep 30 '22 04:09 kelson42

@MohitMaliFtechiz @gouri-panda So, we are good to review here? No regtession in stability of CI foreseen?

hi @kelson42 , @gouri-panda

now this PR is ready for review, i saw CI is more stable on android 21 and android 30 after these fixes.

MohitMaliFtechiz avatar Sep 30 '22 06:09 MohitMaliFtechiz

@MohitMaliFtechiz Would be good to move forward this PR as this is blocking for ither PRs

kelson42 avatar Oct 11 '22 10:10 kelson42

uld be good to move forward this PR as this is blocking

yes we can merge it .

MohitMaliFtechiz avatar Oct 11 '22 12:10 MohitMaliFtechiz

@gouri-panda is the one deciding if this is ready!

kelson42 avatar Oct 11 '22 12:10 kelson42

@MohitMaliFtechiz Sorry for the late review! @kelson42 @MohitMaliDeveloper I'll review this today :)

gouri-panda avatar Oct 11 '22 12:10 gouri-panda

@gouri-panda Can you please have a look a gain to this PR?

kelson42 avatar Oct 20 '22 04:10 kelson42

@kelson42 Ok

gouri-panda avatar Oct 20 '22 12:10 gouri-panda

@MohitMaliFtechiz @gouri-panda status? A rebase with fixing conflicts seems necessary.

kelson42 avatar Nov 01 '22 20:11 kelson42

@kelson42 Sorry! I was focusing on other PR's. I'll review this tomorrow. Yes, we need to resolve the conflicts before merge.

gouri-panda avatar Nov 01 '22 20:11 gouri-panda

hi @gouri-panda , @kelson42 i have resolved the conflict, now it's ready for review.

MohitMaliFtechiz avatar Nov 02 '22 06:11 MohitMaliFtechiz

@MohitMaliFtechiz Sorry, we have again conflicts… this is the kind of problems we have to deal with with long standing PRs.

kelson42 avatar Nov 02 '22 12:11 kelson42

@MohitMaliFtechiz Sorry, we have again conflicts… this is the kind of problems we have to deal with with long standing PRs.

hi @kelson42 , i have resolved the conflicts.

MohitMaliFtechiz avatar Nov 02 '22 13:11 MohitMaliFtechiz

@gouri-panda @MohitMaliFtechiz We are good to merge here?

kelson42 avatar Nov 22 '22 15:11 kelson42

@kelson42 Let me review again.

gouri-panda avatar Nov 22 '22 15:11 gouri-panda

I will merge when it is clear what #3085 really means. So far too many questions are unanswered.

kelson42 avatar Nov 22 '22 16:11 kelson42

@kelson42 Sure!

gouri-panda avatar Nov 22 '22 17:11 gouri-panda