kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Improved method for decoding file name

Open MohitMaliFtechiz opened this issue 2 years ago • 2 comments

Fixes #2875

MohitMaliFtechiz avatar Aug 04 '22 15:08 MohitMaliFtechiz

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.07 :tada:

Comparison is base (3662932) 49.54% compared to head (a7a0249) 49.62%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2935      +/-   ##
=============================================
+ Coverage      49.54%   49.62%   +0.07%     
  Complexity        25       25              
=============================================
  Files            294      294              
  Lines           9972     9973       +1     
  Branches        1327     1325       -2     
=============================================
+ Hits            4941     4949       +8     
  Misses          4347     4347              
+ Partials         684      677       -7     
Impacted Files Coverage Δ
...rg/kiwix/kiwixmobile/core/utils/files/FileUtils.kt 31.77% <83.33%> (+1.40%) :arrow_up:
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 31.98% <0.00%> (+0.10%) :arrow_up:
...rg/kiwix/kiwixmobile/core/search/SearchFragment.kt 63.33% <0.00%> (+4.44%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 04 '22 15:08 codecov[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 04:09 stale[bot]

@MohitMaliFtechiz The underline algorithm is still the same. As I recall, we discussed creating a new file name algorithm. cc @kelson42

hi @gouri-panda , i have changed the underline algorithm for decoding file name. i have used URLUtil.guessFileName() method of android.webkit.

MohitMaliFtechiz avatar Nov 23 '22 11:11 MohitMaliFtechiz

hi @gouri-panda , now this PR is ready for review.

MohitMaliFtechiz avatar Nov 25 '22 12:11 MohitMaliFtechiz

@gouri-panda A full month without review looks like :(

kelson42 avatar Dec 29 '22 11:12 kelson42

hi @gouri-panda , can you please re-review this PR.

MohitMaliFtechiz avatar Jan 04 '23 06:01 MohitMaliFtechiz

hi @gouri-panda , CI is failing right now so i have mark this as draft. Once https://github.com/kiwix/kiwix-android/pull/3191 done i will mark this ready for review.

MohitMaliFtechiz avatar Jan 06 '23 12:01 MohitMaliFtechiz

hi @gouri-panda , now you can re-review this PR.

MohitMaliFtechiz avatar Jan 10 '23 08:01 MohitMaliFtechiz

@MohitMaliFtechiz you did not requested any new review? You have forgotten?

kelson42 avatar Mar 02 '23 16:03 kelson42

@MohitMaliFtechiz you did not requested any new review? You have forgotten?

@kelson42 Ahh, Sorry my bad, i have forgot to request a re-review from you. previously i have requested a re-review from @gouri-panda .

MohitMaliFtechiz avatar Mar 03 '23 06:03 MohitMaliFtechiz