kiwix-android
kiwix-android copied to clipboard
Improved method for decoding file name
Fixes #2875
Codecov Report
Patch coverage: 83.33
% and project coverage change: +0.07
:tada:
Comparison is base (
3662932
) 49.54% compared to head (a7a0249
) 49.62%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #2935 +/- ##
=============================================
+ Coverage 49.54% 49.62% +0.07%
Complexity 25 25
=============================================
Files 294 294
Lines 9972 9973 +1
Branches 1327 1325 -2
=============================================
+ Hits 4941 4949 +8
Misses 4347 4347
+ Partials 684 677 -7
Impacted Files | Coverage Δ | |
---|---|---|
...rg/kiwix/kiwixmobile/core/utils/files/FileUtils.kt | 31.77% <83.33%> (+1.40%) |
:arrow_up: |
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt | 31.98% <0.00%> (+0.10%) |
:arrow_up: |
...rg/kiwix/kiwixmobile/core/search/SearchFragment.kt | 63.33% <0.00%> (+4.44%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
@MohitMaliFtechiz The underline algorithm is still the same. As I recall, we discussed creating a new file name algorithm. cc @kelson42
hi @gouri-panda ,
i have changed the underline algorithm for decoding file name. i have used URLUtil.guessFileName()
method of android.webkit
.
hi @gouri-panda , now this PR is ready for review.
@gouri-panda A full month without review looks like :(
hi @gouri-panda , can you please re-review this PR.
hi @gouri-panda , CI is failing right now so i have mark this as draft. Once https://github.com/kiwix/kiwix-android/pull/3191 done i will mark this ready for review.
hi @gouri-panda , now you can re-review this PR.
@MohitMaliFtechiz you did not requested any new review? You have forgotten?
@MohitMaliFtechiz you did not requested any new review? You have forgotten?
@kelson42 Ahh, Sorry my bad, i have forgot to request a re-review from you. previously i have requested a re-review from @gouri-panda .