kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Published 20 hours ago • verified publisher icon kiwix

Host Books don't update on Application

Open gouri-panda opened this issue 5 years ago • 3 comments

Describe the bug UnSelected Host books are showing on Hosting.

Expected behavior Only Selected Host books should show.

Steps to reproduce the behavior:

  1. Start the server on HostFragment
  2. Unselect one or more zim files
  3. See the unselected books are showing (On Mobile device)

Environment

  • Version of Kiwix Android : develop
  • Device : 10
  • OS version : pixel

gouri-panda avatar Dec 03 '20 09:12 gouri-panda

Is this a dupe of https://github.com/kiwix/kiwix-android/issues/2447 ?

macgills avatar Dec 03 '20 11:12 macgills

@macgills #2447 that is showing on the browser and this issue is related to mobile application

gouri-panda avatar Dec 03 '20 11:12 gouri-panda

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Feb 02 '21 04:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 10:08 stale[bot]

@MohitMaliFtechiz Is that still a valid bug?

kelson42 avatar Jan 26 '23 19:01 kelson42

@MohitMaliFtechiz Is that still a valid bug?

ok @kelson42 I will check this bug.

MohitMaliFtechiz avatar Jan 27 '23 05:01 MohitMaliFtechiz

@kelson42 , i have tested this. i found when i select only 2-3 books and un-select all other book. then all books are showing in hosting, i'm attaching a video.

https://user-images.githubusercontent.com/34593983/215048456-de01da84-a61f-4f20-aac6-affe42f2c5a3.mp4

It's a valid bug.

MohitMaliFtechiz avatar Jan 27 '23 09:01 MohitMaliFtechiz

@MohitMaliDeveloper Thank you for testing. I don't really understand why the checkbox disappear when server is running. I propose to just keep them always visible and if someone change (adding or removing a book) while service is running, then service is restarted.

kelson42 avatar Jan 27 '23 09:01 kelson42

@kelson42 ,

I propose to just keep them always visible and if someone change (adding or removing a book) while service is running, then service is restarted

I have created separate ticket for this https://github.com/kiwix/kiwix-android/issues/3219

i have tested this. i found when i select only 2-3 books and un-select all other book. then all books are showing in hosting

For this, i have placed a fix https://github.com/kiwix/kiwix-android/pull/3218

MohitMaliFtechiz avatar Jan 27 '23 10:01 MohitMaliFtechiz