kiwix-android icon indicating copy to clipboard operation
kiwix-android copied to clipboard

Invite user to delete old versions of the same content

Open Popolechien opened this issue 5 years ago • 10 comments

Currently most files have a name_yyyy-mm naming convention, but if I have wikipedia_en_all_mini_2020-08 and want to update it I end up with two nearly identical files (and twice as much space used up). I still need to manually delete the "old version.". Kiwix should be able to recognize updates and delete/overwrite as needed.

Popolechien avatar Sep 22 '20 14:09 Popolechien

We need to agree first about what to do. This can be done based on the ZIM name metadata (so not the filename). But I disagree that we should automatically delete it, but we could provide an invite asking if the user wants to delete the older version of the file.

kelson42 avatar Sep 22 '20 19:09 kelson42

@kelson42 honest question: why not delete it automatically? What's the use case?

Popolechien avatar Sep 22 '20 20:09 Popolechien

@Popolechien If content is downloaded at user initiative, it should be deleted at user initiative. I strongly oppose to do that automatically. It is a principle.

kelson42 avatar Oct 12 '20 07:10 kelson42

@kelson42 yeah I wasn't very clear with the scenario I had in mind but obviously it should ask for confirmation, as it does in most cases. What I meant to say is that the default outcome of a new download should not be having two files sitting side by side without the user being notified that the second download can replace the older one (and confirm with a single click).

Popolechien avatar Oct 12 '20 07:10 Popolechien

Can I work on this?

epicadk avatar Oct 16 '20 12:10 epicadk

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Dec 17 '20 13:12 stale[bot]

@kelson42 I would like to work on this issue. But to start my work I need to know how to recreate/test this. To be more precise how do I get new and old versions of the same file on demand so that I can update it.

ManasviPatidar avatar Jan 08 '21 05:01 ManasviPatidar

@ManasviPatidar The easiest way is to head over at download.kiwix.org/zim : it keeps the two last versions of a zim file (so at this stage probably xxxx-2020-12.zim and xxxx-2021-01.zim)

Popolechien avatar Jan 08 '21 06:01 Popolechien

@ManasviPatidar At https://download.kiwix.org/zim, you have always two revisions of a content (different months). I think the dialog to invite to delete an older content should happen at the time a new content is put in the library. Basically, if a new content "replace" an old content. @mgautierfr I believe the primitive to identify the "duplicate" should be anyway in the kiwix-lib. Would you be able to enlight us on this?

kelson42 avatar Jan 08 '21 10:01 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Mar 19 '21 23:03 stale[bot]

Basically a duplicate of #57

kelson42 avatar Jan 11 '23 19:01 kelson42