Put Webview Controls in NavView

[rgaudin]

Describe the bug There's a white line between bottom app nav and android nav

Expected behavior No space between those those navigation bars. Not that scrolling fixes it.

Steps to reproduce the behavior:

1. Launch kiwix android
2. launch a ZIM

Screenshots

Environment

• Version of Kiwix Android : current develop branch
• Device :
• OS version : 5.1.1

[gouri-panda]

@rgaudin I can't find this bug in both my physical device and emulator. Both are running on 5.1. Do you see this bug in all 5.1.1 devices?

[rgaudin]

I only have this device which is 5.1.1. I just checked that it's still present in current develop (though maybe #2411 could have fixed it)

[macgills]

There is still the issue that this white line will appear when you scroll. @Frans-Lukas didn't we create a ticket to fine tune this animation further down the line? I couldn't find it searching the issues.

I mention it because it might be possible to get 2 birds with 1 stone. It might be messy but we we could put the webview controls in the bottom nav view and only show them on the reader fragment. A nasty trick but we can stop calculating heights and doing all this other stuff and this white line would be impossible and we would gain smooth animation on/off screen

[Frans-Lukas]

Basically making the bottom nav view double in height in the reader fragment? We never created a ticket, only mentioning it as a to-do. Another solution could be to make the background black behind the nav bars, but I prefer putting the controls in the nav bar.

[macgills]

Ticket renamed, there will be some overhead with forwarding the events of the nav view, I imagine the readerFragment will implement some interface but overall I think we should see a decrease in lines of code, there is more than 1 ambiguous "ehhhh move the bar now" chunks about the place

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

Still there, at least on my Android6 tablet.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

@rgaudin @macgills Inreally wonder if this big is still valid with latest code base? Even if still there, considering this is a very old version of Android, maybe this is not worse to investigate?

[rgaudin]

No idea. Have you tried with your android6 tablet to see if it's still present in latest release?

[gouri-panda]

I think it's still a valid bug. I haven't tested this but I'll test this after i get back.

[MohitMaliFtechiz]

hi @kelson42 , @gouri-panda , yes this is a valid bug. I have tried to test with Nexus 10 tablet and the white line is still present there.

The white line is gone after scrolling.

Landscape Mode

Landscape mode after scolling

[kelson42]

@MohitMaliFtechiz Can you please fix it?

[MohitMaliFtechiz]

@kelson42 , yes, i'm working on it.