Find in page conflated with Find in ZIM

[Popolechien]

Basically when I start typing text the "find in page" button disappears and the search only applies to the whole zim.

I would probably advocate that "search" and "find in page" be dissociated (the latter being pushed to a menu item), unless there's an elegant way to switch from or select either on that search bar.

[macgills]

This bug was also fixed in #1771 , the find in page buttons visibility is now controlled by whether or not there is text in the search field.

I do agree that Find In Page should be accessible from the main screen, potentially as an overflow option. It probably wasn't because of the overpopulation of that list that exists now

[kelson42]

Could we split things in two tickets? Here we have a bug which needs to be fixed. The other part is an idea of improvement (which I'm not really in favor of).

[macgills]

The bug is fixed

[macgills]

chrome has Find in Page in its' overflow menu, as an example

[kelson42]

The original discussion about that is at #154. I'm not sure I see new arguments here to chance the current behaviour.

[macgills]

We could try to adopt a more browser like behaviour and abandon the search icon because it is the search icon that is confusing people.

If we had a chrome-like "address bar" at the top with the title in it and we could only open Search by clicking in it then I think people would look in the overflow menu for Find in Page

[Popolechien]

Sounds good/reasonable to me. Obviously the two-in-one approach isn't ideal, so let's shamelessly copy what others have already figured out.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[kelson42]

I will refresh/reassess this ticket.

[kelson42]

@MohitMaliFtechiz Please look at this and make a proposal how we coulf tackle this ticket

[MohitMaliFtechiz]

@kelson42 We can move FIND IN PAGE to the overflow menu like Chrome(Since this is the place where we can take it) but before changing it we have a few points to consider. I have noticed a few things about the current behavior, and if we move this button to the overflow menu then we have these benefits.

• It will remove the FIND IN PAGE button from the SearchScreen as its functionalities is not there.
• It will increase the search box area. if the user types a long search term he will easily see that.
• If any user only wants to use the FIND IN PAGE feature he can directly use that from the overflow menu. For now, the user has to open the search and type a single character in it to initiate the FIND IN PAGE feature. It will also start the search which is unnecessary for those who only want to use the FIND IN PAGE feature(The search will unnecessarily be triggered which is useless in this case).

https://github.com/kiwix/kiwix-android/assets/34593983/6a728910-52fc-44f6-8ef5-1763d307e189

Apart from these small points, the current approach is not too bad, it has its own benefits.

• The current UI looks good from the UI, and user point of view. Since it has 2 search functionalities(Search for entry and search in page) at the same place the user easily use both functionalities from one place, and in most cases, it is beneficial for the users to have the same type of functionality at one place(Personally I like the current approach since it allows me to use the same type of functionality from a single screen).
• Both functionalities do not impact each other as these functionalities are implemented on different screens. For example Search in performed inside the SearchFragment, and the FIND IN PAGE functionality is performed in the reader screen.
• The current UI is familiar to the users, and they are habited to it as they have been using it for a long time.

These are my current observations. @kelson42 let me know what do you think?

[kelson42]

@MohitMaliFtechiz Thank you for wrapping up the pros and cons. Whatbwoukd be your personal recommandation?

[MohitMaliFtechiz]

@kelson42 Personally I would like to have the current approach but with an enhancement in code. I want to make the FIND IN PAGE button always clickable, because it will directly open this feature without triggering the search in ZIM file(which is unnecessary when the user only wants to use the FIND IN PAGE functionality).

[kelson42]

@MohitMaliFtechiz I will think a bit more about it and will come back to you

[Mitia99]

chrome has Find in Page in its' overflow menu, as an example

I also think that the FIND IN PAGE feature should be in the overflow menu.

The current UX is confusing.