Kiwi icon indicating copy to clipboard operation
Kiwi copied to clipboard

[do not merge] Upgrade bootstrap-switch from 3.3.4 to 3.4.0

Open snyk-bot opened this issue 4 years ago β€’ 4 comments

Snyk has created this PR to upgrade bootstrap-switch from 3.3.4 to 3.4.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
  • The recommended version is 2 versions ahead of your current version.
  • The recommended version was released a year ago, on 2019-04-13.
Release notes
Package name: bootstrap-switch
  • 3.4.0 - 2019-04-13
  • 3.3.5 - 2019-04-13
  • 3.3.4 - 2017-02-25
    • Fix Object.assign not working for IE <= 11 #616
from bootstrap-switch GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

πŸ›  Adjust upgrade PR settings

πŸ”• Ignore this dependency or unsubscribe from future upgrade PRs

snyk-bot avatar Mar 23 '20 23:03 snyk-bot

Coverage Status

Coverage remained the same at 75.327% when pulling 36fbd683e65bb2cae697ce67e3f8ad489c2f53ac on snyk-upgrade-a8947984442f9b74f44fc71268738ce9 into 6cd7188387dbad8581e506d38243d343621d37db on master.

coveralls avatar Mar 23 '20 23:03 coveralls

Codecov Report

Merging #1450 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1450   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         123      123           
  Lines        4644     4644           
  Branches      569      569           
=======================================
  Hits         3482     3482           
  Misses        966      966           
  Partials      196      196           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6cd7188...36fbd68. Read the comment docs.

codecov[bot] avatar Mar 23 '20 23:03 codecov[bot]

v3.4 pulls bootstrap v4 and I don't think this is compatible with Patternfly 3.

atodorov avatar Mar 24 '20 01:03 atodorov

unfortunately, this project is nearly dead.

the last commit is from a year ago, PRs and issues are hanging. for instance - https://github.com/Bttstrp/bootstrap-switch/pull/700 this PR fixes the issue that does not allow us to migrate to 3.4.0

asankov avatar Apr 13 '20 21:04 asankov

v3.4.0 will be installed with missing peer dependency bootstrap@^4.3.1 but that doesn't seem to affect anything. We're onnly using the CSS file from this package to make checkboxes look as toggle buttons.

atodorov avatar Nov 10 '22 11:11 atodorov