Kiwi icon indicating copy to clipboard operation
Kiwi copied to clipboard

Published 20 hours ago • verified publisher icon kiwitcms

Migrate to Patternfly 4

Open asankov opened this issue 5 years ago • 8 comments

Patternfly 4 has been out for almost a year now, so I think it is a good idea to upgrade.

This could be helpful: https://www.patternfly.org/v4/get-started/migrate

asankov avatar Jan 25 '20 21:01 asankov

@chetas411 not sure why your comments don't come up in GitHub. I've received notifications for them.

atodorov avatar Feb 18 '21 07:02 atodorov

Hi @atodorov , yeah I commented that I am interested in this issue

chetas411 avatar Feb 18 '21 07:02 chetas411

Just to confirm what I read on GSoC 2021 page is that, now we need to migrate the UI to patternfly v4 using React ?

chetas411 avatar Feb 18 '21 07:02 chetas411

@atodorov Can you provide the directories I should start to look up for this?

chetas411 avatar Feb 18 '21 07:02 chetas411

Hi @atodorov , yeah I commented that I am interested in this issue

Assigned to you.

Just to confirm what I read on GSoC 2021 page is that, now we need to migrate the UI to patternfly v4 using React ?

There are 2 parts to this issue:

  1. We're using Patternfly visual components with their HTML + CSS implementation. That needs to be migrated to v4 and the syntax/css file imports, etc adjusted where necessary. Pages like login & registration, dashboard, telemetry pages, maybe search pages are easier b/c there are less UI widgets inside of them. These need to be migrated one by one, ideally we can ship both v3 & v4 together for some time. If not we'll have to make all changes in a branch and merge in one huge PR.

  2. Patternfly (as in being a standard) has implementations in HTML+CSS, Angular and React. The testruns/get.html and testplans/get.html pages in particular keep a lot of internal state in their JavaScript code which makes them suitable for rewriting them with React. However this is secondary b/c these are very huge pages with tons of functionality and we're still uncertain how that could work. Thus the preference is that all pages will be migrated to Patternfly v4 in HTML+CSS implementation first and afterwards the most heavy pages will be reimplemented with Patternfly v4 in its React implementation.

If you'd like you can start working on item 1) and as we go along we'll figure out the process.

atodorov avatar Feb 18 '21 07:02 atodorov

Okay thanks I will be needing some time to get familiar with the codebase and then I will report you soon

chetas411 avatar Feb 18 '21 07:02 chetas411

@atodorov Sorry I will not be able to do this issue.

chetas411 avatar Feb 19 '21 04:02 chetas411

Possible new alternatives:

  • https://github.com/djangoflow/flutter-djangoflow or https://flutter.dev/ directly
  • https://github.com/sparckles/starfyre

atodorov avatar Feb 19 '24 10:02 atodorov