kiwiirc icon indicating copy to clipboard operation
kiwiirc copied to clipboard

Update to Colour Picker + Emoji picker

Open AllanOcelot opened this issue 5 years ago • 7 comments

This PR updates both the Colour Picker and the Emoji picker to look and function more inline with modern Kiwi standards.

closes #915

AllanOcelot avatar May 09 '19 14:05 AllanOcelot

TODO:

  • Make plus icon smaller / thinner
  • Animate between the two classic/extended colour schemes ( Preferably slide right / left )
  • Make borders for both colour and emoji picker thiner
  • Ensure borders + content is themed up for each theme

AllanOcelot avatar May 09 '19 16:05 AllanOcelot

Isn't this removing the text colour schemes for each theme that we spent time going over previously?

prawnsalad avatar May 25 '19 18:05 prawnsalad

@prawnsalad - yes, this removes the theme overrides for colours, as we are essentially quadrupling the colours we have, made more sense to me to have the 98, giving our users more choice to use an appropriate colour

AllanOcelot avatar May 25 '19 20:05 AllanOcelot

We tweaked the first set of colours for each theme so that they better suited. ie. yellow on the default theme was slightly darker so its readable. The 16-98 colours are the only ones that should never change between themes.

prawnsalad avatar May 25 '19 20:05 prawnsalad

i am testing this PR at the moment and when you type just numbers it does not show the first number for example if i did 1111 it would only show 111, We have checked this out on all themes on our server and its the same issue. Have checked this out on the builds site too with same issue

MrGrays avatar Aug 09 '19 21:08 MrGrays

Are there any plans to merge the changes proposed by AllanOcelot?

More than 4 years have passed and we are still limited to the 16 color palette from the previous century.

Would it be possible to implement the new color picker as a plugin, so that the users needing it can actually use it (independently of what happens with this PR)?

marthellius avatar Jul 19 '23 01:07 marthellius

I have a new 9025 color palette in the wings which will be better.

clort81 avatar Aug 21 '23 17:08 clort81