cubeide-sd-card icon indicating copy to clipboard operation
cubeide-sd-card copied to clipboard

Declare spiTimerTickStart and spiTimerTickDelay as static

Open vpreatoni opened this issue 3 years ago • 1 comments

Hi! great work!! I've seen very crappy code regarding SD SPI and STM32 but yours is very clean and tidy.

Just a suggestion, declare instead:

static uint32_t spiTimerTickStart;
static uint32_t spiTimerTickDelay;

They are not used outside user_diskio_spi.c file, so it is a good practice declare them static globals.

vpreatoni avatar Jan 15 '22 13:01 vpreatoni

Hi there, you can submit a PR with this if you would like, I will accept it.

kiwih avatar Mar 16 '22 17:03 kiwih