helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

[error-pages] Update kubernetes ingress api to `v1`

Open theonlysinjin opened this issue 3 years ago • 1 comments

What this PR does / why we need it:

We are upgrading our kubernetes cluster to v1.22 and the current chart uses a (now) deprecated kubernetes API You can see here that it is being deprecated and then in this list you can see that it is not being included at all

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #454

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] DCO signed
  • [x] Chart Version bumped (if the pr is an update to an existing chart)
  • [x] Variables are documented in the README.md
  • [x] Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

theonlysinjin avatar Aug 04 '22 11:08 theonlysinjin

Some of your commit are not signed. Can you pls sign your commits.

rpahli avatar Sep 29 '22 08:09 rpahli

Thanks @rpahli sorry for the delay, Signed that one commit and rebased.

theonlysinjin avatar Oct 26 '22 13:10 theonlysinjin